From 4e90f6161465a95df6682dbc8eaa3c32814fb9ab Mon Sep 17 00:00:00 2001 From: phazei Date: Mon, 22 Sep 2014 20:13:59 -0700 Subject: [PATCH 1/2] Avoid question mark and asterisk in folder names to prevent windows filesystem issues. A previous commit introduced a folder with a question mark and an asterisk which are invalid NTFS folder name characters and prevented checkout on those systems. --- src/Symfony/Component/Finder/Tests/FinderTest.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Symfony/Component/Finder/Tests/FinderTest.php b/src/Symfony/Component/Finder/Tests/FinderTest.php index 161a21902992a..7738a33546203 100644 --- a/src/Symfony/Component/Finder/Tests/FinderTest.php +++ b/src/Symfony/Component/Finder/Tests/FinderTest.php @@ -586,11 +586,11 @@ public function testIteratorKeys(Adapter\AdapterInterface $adapter) public function testRegexSpecialCharsLocationWithPathRestrictionContainingStartFlag(Adapter\AdapterInterface $adapter) { $finder = $this->buildFinder($adapter); - $finder->in(__DIR__.DIRECTORY_SEPARATOR.'Fixtures'.DIRECTORY_SEPARATOR.'r+e.g?e*x[c]a(r)s') + $finder->in(__DIR__.DIRECTORY_SEPARATOR.'Fixtures'.DIRECTORY_SEPARATOR.'r+e.gex[c]a(r)s') ->path('/^dir/'); - $expected = array('r+e.g?e*x[c]a(r)s'.DIRECTORY_SEPARATOR.'dir', - 'r+e.g?e*x[c]a(r)s'.DIRECTORY_SEPARATOR.'dir'.DIRECTORY_SEPARATOR.'bar.dat',); + $expected = array('r+e.gex[c]a(r)s'.DIRECTORY_SEPARATOR.'dir', + 'r+e.gex[c]a(r)s'.DIRECTORY_SEPARATOR.'dir'.DIRECTORY_SEPARATOR.'bar.dat',); $this->assertIterator($this->toAbsoluteFixtures($expected), $finder); } From 10ff674c2a618ba843db3e7510ea15cf4906e687 Mon Sep 17 00:00:00 2001 From: Adam Date: Tue, 23 Sep 2014 03:23:54 +0000 Subject: [PATCH 2/2] Removed question mark and asterisk from folder name to fix windows filesystem issues --- .../Fixtures/{r+e.g?e*x[c]a(r)s => r+e.gex[c]a(r)s}/dir/bar.dat | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename src/Symfony/Component/Finder/Tests/Fixtures/{r+e.g?e*x[c]a(r)s => r+e.gex[c]a(r)s}/dir/bar.dat (100%) diff --git a/src/Symfony/Component/Finder/Tests/Fixtures/r+e.g?e*x[c]a(r)s/dir/bar.dat b/src/Symfony/Component/Finder/Tests/Fixtures/r+e.gex[c]a(r)s/dir/bar.dat similarity index 100% rename from src/Symfony/Component/Finder/Tests/Fixtures/r+e.g?e*x[c]a(r)s/dir/bar.dat rename to src/Symfony/Component/Finder/Tests/Fixtures/r+e.gex[c]a(r)s/dir/bar.dat