[Templating] #9071 array param for EngineInterface::render() #10832
Conversation
We allow an array to be given as param to Symfony/Component/Templating/EngineInterface::render() and Symfony/Bundle/FrameworkBundle/Templating /EngineInterface::renderView(). We modify Symfony\Bridge \Twig\TwigEngine so it accepts an array as param to TwigEngine::render(). We add a test for that. Controller:render() and ::renderView() now accept array as parameter.
|
This is a BC break, as it changes the EngineInterface (an engine is now supposed to accept arrays as well) |
|
Ok, I was expecting that. In this case, I think it is impossible to fix #9071 without :
Neither of those seem an acceptable solution. |
|
BC-break will occurs only in some edge cases. If your engine implementation doesn't supports arrays, so you probably don't know about this feature and not use it. |
|
@Koc Teh issue is that if we update the interface to accept arrays, all implementations need to accept them. Otherwise, consumers of the interface would not be able to use arrays. and for instance, the delegating engine does not support arrays in this PR, so you cannot use them anymore if you enable several engines |
|
And the PHP engine does not support that either. So, I'm closing this as the BC break is not worth it. Talking about templating engines, I would really like to remove support for PHP at some point to avoid this additional layer we have right now that prevents to take advantages of some nice Twig features. But that's probably for 3.0 if ever. |
We allow an array to be given as param to Symfony/Component/Templating/EngineInterface::render() and Symfony/Bundle/FrameworkBundle/Templating/EngineInterface::renderView(). We modify Symfony\Bridge\Twig\TwigEngine so it accepts an array as param to TwigEngine::render(). We add a test for that. Controller:render() and ::renderView() now accept array as parameter.
This change asks implementer of
EngineInterface::render()to accept arrays as parameters, but it will never break existing code, as it is just a change in the docblock, so I do not know if it is a BC break.