8000 [RFC] Move tests dependent on url resources to travis localhost so it can speed these tests · Issue #9907 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content
8000

[RFC] Move tests dependent on url resources to travis localhost so it can speed these tests #9907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cordoval opened this issue Dec 30, 2013 · 2 comments
Closed

[RFC] Move tests dependent on url resources to travis localhost so it can speed these tests #9907

cordoval opened this issue Dec 30, 2013 · 2 comments

Comments

@cordoval
Copy link
Contributor

some tests are slowing down the suite because they download resources from certain external web urls. As @stloyd suggested we can move these to download from the localhost within travis so that the tests actually go faster. This could potentially create fixtures of files and thereby make a bit bigger the symfony repository however i think is a feasible option to avoid slowing down the test suite.

👶
@cordoval cordoval mentioned this issue Dec 30, 2013
Merged
@fabpot
Copy link
Member
fabpot commented Apr 28, 2014

Can you list the resources that are actually downloaded during tests?

@stof
Copy link
Member
stof commented Apr 28, 2014

https://github.com/symfony/symfony/blob/339c0c809953097d5927e7adb30a65219a269b7a/src/Symfony/Component/Finder/Tests/Iterator/RecursiveDirectoryIteratorTest.php and

symfony/src/Symfony/Component/Finder/Tests/FinderTest.php

Line 836 in 02fdbb2

public function testNonSeekableStream()

but making these tests run locally would require installing an FTP server on Travis, which would probably be even slower

@fabpot fabpot closed this as completed Apr 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fabpot @cordoval @stof
0