8000 [Translator] FileDumper shuld not impose a file naming scheme. · Issue #9845 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Translator] FileDumper shuld not impose a file naming scheme. #9845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
goetas opened this issue Dec 23, 2013 · 0 comments
Closed

[Translator] FileDumper shuld not impose a file naming scheme. #9845

goetas opened this issue Dec 23, 2013 · 0 comments
Labels
Enhancement Translation

Comments

@goetas
Copy link
Contributor
goetas commented Dec 23, 2013

To be "framework independent", Translator component shoud not impose a naming convention for dumped files.

I should be able to use this path template:
[anypath]/locale/domain.[extension]

The current implementation of Symfony\Component\Translation\Dumper\FileDumper::dump() forces [anypath]/domain.locale.[extension] template.
@florianv florianv mentioned this issue Dec 23, 2013
Merged
fabpot added a commit that referenced this issue Mar 3, 2014
@fabpot
feature #9852 [Translation] Added template for relative file paths in…
c4b8e03 
… FileDumper (florianv)

This PR was merged into the 2.5-dev branch.

Discussion
----------

[Translation] Added template for relative file paths in FileDumper

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #9845
| License       | MIT
| Doc PR        |

Added ability to support templates for relative paths to translation files.
The file dumpers will try to create the directories if not existing.
Also made `IcuResFileDumper` extending `FileDumper`.

Commits
-------

a04175e Changed placeholders
623d149 Added a ConcreteDumper
84f0902 [Translation] Added template for relative file paths
@fabpot fabpot closed this as completed Mar 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement Translation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fabpot @goetas
0