8000 [EncoderFactory] merge FOSAdvancedEncoder funtionality · Issue #9743 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content
8000

[EncoderFactory] merge FOSAdvancedEncoder funtionality #9743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tamirvs opened this issue Dec 11, 2013 · 1 comment
Closed

[EncoderFactory] merge FOSAdvancedEncoder funtionality #9743

tamirvs opened this issue Dec 11, 2013 · 1 comment
Labels
Security

Comments

@tamirvs
Copy link
Contributor
tamirvs commented Dec 11, 2013

I was going to write a PR for FOSAdvancedEncoder for the new encoders (bcrypt, pbkdf2) and I noticed it's pretty much a duplicate of the core EncoderFactory. it seems a waste to maintain a separate bundle for this simple functionality.
My suggestion is to add this small feature to the core EncoderFactory.

  • Does anybody else think the same?
  • I need an idea how to build the new config so it won't have BC issues

Use case: different encoder (or bcrypt cost) for user/admin
@sstok
Copy link
Contributor
sstok commented Dec 12, 2013

👍

@tamirvs tamirvs mentioned this issue Jan 11, 2014
Closed
fabpot added a commit that referenced this issue Jan 18, 2014
@fabpot
feature #10005 [Security] Added named encoders to EncoderFactory (tam…
4ad343b 
…irvs)

This PR was squashed before being merged into the 2.5-dev branch (closes #10005).

Discussion
----------

[Security] Added named encoders to EncoderFactory

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #9743
| License       | MIT
| Doc PR        | -

This PR is basically merging FOSAdvancedEncoder. I think it's better than having a separate bundle that most of it's code is a copy of the core.
A use case is: having a different encoders or bcrypt cost based on the user's roles.

Commits
-------

c69e2ca [Security] Added named encoders to EncoderFactory
@fabpot fabpot closed this as completed Jan 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Security
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fabpot @sstok @tamirvs
0