[Form][Bug] Embedded form validation bubbling #8557

sirian · 2013-07-24T12:12:48Z

See example of embedded form.

class Item
{
    public $title;
}

class Foo implements \IteratorAggregate
{
    public $items;

    public function __construct()
    {
        $this->items = [new Item()];
    }

    public function getIterator()
    {
        return new \ArrayIterator([
            'items' => $this->items
        ]);
    }
}

class ItemType extends AbstractType
{
    public function buildForm(FormBuilderInterface $builder, array $options)
    {
        $builder->add('title', 'text');
    }

    public function setDefaultOptions(OptionsResolverInterface $resolver)
    {
        $resolver->setDefaults([
            'data_class' => __NAMESPACE__ . '\Item',
            'error_bubbling' => false
        ]);
    }


    public function getName()
    {
        return 'item';
    }
}

class FooType extends AbstractType
{
    public function buildForm(FormBuilderInterface $builder, array $options)
    {
        $builder->add('items', 'collection', [
            'type' => new ItemType()
        ]);
    }
    public function setDefaultOptions(OptionsResolverInterface $resolver)
    {
        $resolver->setDefaults([
            'data_class' => __NAMESPACE__ . '\Foo',
            'error_bubbling' => false
        ]);
    }

    public function getName()
    {
        return 'foo';
    }
}

Resources/config/validation.yml:

Foo\Item:
    properties:
        title:
            - NotBlank:
                message: XXX

Now when I call this

$form = $this->get('form.factory')
    ->createNamed('form', new FooType(), new Foo(), [
        'csrf_protection' => false,
        'error_bubbling' => false
    ]);
;

$form->submit([]);
var_dump($form->getErrors());

Error from items[0].title bubbles to the root of the form

array(1) {
  [0]=>
  object(Symfony\Component\Form\FormError)#534 (4) {
    ["message":"Symfony\Component\Form\FormError":private]=>
    string(3) "XXX"
    ["messageTemplate":protected]=>
    string(3) "XXX"
    ["messageParameters":protected]=>
    array(0) {
    }
    ["messagePluralization":protected]=>
    NULL
  }
}

The text was updated successfully, but these errors were encountered:

webmozart · 2013-07-31T13:47:30Z

The reason for your problem is that Foo implements \IteratorAggregate. Currently, the Form component enables object traversal for the data of the root form when launching the validation. Consequently, the generated violation has the path

data[items][0].title

instead of

data.items[0].title

To fix your problem, you can either remove the \IteratorAggregate interface from Foo or overwrite the property path for all fields in FooType:

$builder->add('items', 'collection', [
    'type' => new ItemType(),
    'property_path' => '[items]',
]);

#8617 will also be a solution to this problem, but I can't tell yet when exactly this will be implemented.

jakzal mentioned this issue Jul 27, 2013

Forms: @Assert\Count(max="2") error mapping not working in collection type #8516

Closed

webmozart mentioned this issue Jul 31, 2013

[Validator] Control traversal on class level #8617

Closed

webmozart closed this as completed Jul 31, 2013

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

[Form][Bug] Embedded form validation bubbling #8557

[Form][Bug] Embedded form validation bubbling #8557

Uh oh!

Uh oh!

[Form][Bug] Embedded form validation bubbling #8557

[Form][Bug] Embedded form validation bubbling #8557

Comments

Uh oh!