8000 [Locale] StubIntlDateFormatterTest::testParseErrorStub · Issue #6387 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Locale] StubIntlDateFormatterTest::testParseErrorStub #6387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mmenozzi opened this issue Dec 16, 2012 · 6 comments
Closed

[Locale] StubIntlDateFormatterTest::testParseErrorStub #6387

mmenozzi opened this issue Dec 16, 2012 · 6 comments
Labels
Intl

Comments

@mmenozzi
Copy link
Contributor

Hi,
the test StubIntlDateFormatterTest::testParseErrorStub doesn't pass on my machine.

PHPUnit 3.7.9 by Sebastian Bergmann.

Configuration read from /Users/manuele/Work/Projects/symfony/phpunit.xml.dist

....FF

Time: 3 seconds, Memory: 121.00Mb

There were 2 failures:

1) Symfony\Component\Locale\Tests\Stub\StubIntlDateFormatterTest::testParseErrorStub with data set #4 ('y-M-d', '1970/1/1')
Failed asserting that 0 is false.

/Users/manuele/Work/Projects/symfony/src/Symfony/Component/Locale/Tests/Stub/StubIntlDateFormatterTest.php:858

2) Symfony\Component\Locale\Tests\Stub\StubIntlDateFormatterTest::testParseErrorStub with data set #5 ('yy-M-d', '70/1/1')
Failed asserting that 0 is false.

/Users/manuele/Work/Projects/symfony/src/Symfony/Component/Locale/Tests/Stub/StubIntlDateFormatterTest.php:858

FAILURES!
Tests: 6, Assertions: 30, Failures: 2.

I've intl extension loaded and my ICU version is 4.6. All other tests of Locale component pass.
Do you know what I'm missing?
@mmenozzi
Copy link
Contributor Author

@hason I see that you committed (5fe58bf) these specific dataset that on my machine fails. Can you help me to understand what is wrong? Thank you.

@mmenozzi
Copy link
Contributor Author

@hason @eriksencosta Ok, now it's clear: datasets #4 an #5 are incompatible with this commit: 0d442c7

I think that we should change FullTransformer::getReverseMatchingRegExp to make slash and dash interchangeable only for ICU 4.8.

What do you think? Let me know.

@mmenozzi
Copy link
Contributor Author
mmenozzi commented Jan 4, 2013

@fabpot, @hason or @eriksencosta can you tell to me what do you think about that?

@cordoval
Copy link
Contributor
cordoval commented Dec 6, 2013

@mmenozzi as of today, the class does not exist but the method has been moved to an abstract class called AbstractIntlDateFormatterTest::parseDashSlashProvider. Do you still have problems with this test failing?

Also why your system is different? what is different in your system? This is very rare.

@mmenozzi
Copy link
Contributor Author

Hi @cordoval, thank you for your response.

I have just cloned the Locale component from master. All tests are skipped but green. The test (StubIntlDateFormatterTest::testParseErrorStub) which I was talking about a year ago doesn't exists anymore.

What do you mean when you say that my system is different?
I have a Mac Book Pro (OS X 10.9), PHP 5.4.16, intl enabled and ICU version 4.6. I don't think that I have any particular (or rare) configurations.

Consider that the CI build of Symfony runs on a debian based linux with ICU 4.8 so it's always possible to have regressions due to system dependencies.

Let me know.

@fabpot
Copy link
Member
fabpot commented Dec 24, 2014

Closing this old ticket as the intl sub-system has been totally changed recently. Feel free to reopen if this issue still exists.

@fabpot fabpot closed this as completed Dec 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Intl
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fabpot @cordoval @mmenozzi
0