8000 [Runtime] error_reporting behaviour changed, resulting in a Sentry/Sentry change · Issue #58847 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content
[Runtime] error_reporting behaviour changed, resulting in a Sentry/Sentry change #58847
Closed
@jorenMartens

Description

@jorenMartens

Symfony version(s) affected

6.4.13

Description

In symfony/runtime@ba1a6cb#diff-b43d5730878f1cf5695e89f3df76fc6eaa9dc3c253a62cb60e84a668834942f3R33 errorHandler::register is moved outside the debug check, resulting in error_reporting(-1) changing.

Sentry/Sentry uses this config, return $this->options['error_types'] ?? error_reporting();. Now everything sends to Sentry including deprecations.

Is this supposed to happen and do we need to make app changes, or am I correct and should the behavior be the same?

There is also another behavior change zend.assertions, see https://github.com/symfony/symfony/pull/58372/files#diff-2313045898729366b768acf6e83fef5c1a980c8a80439cc8baf8a656e4a7a2e9R43

NoiseByNorthwest copy: why are you disabling assertions in non-debug mode? We are relying on assertions in production mode and this change breaks our application.

How to reproduce

Install a clean project with Sentry error logging, previously only errors were logged depending on your error_reporting configuration. Now everything logs (including deprecations)

Possible Solution

Revert moving $errorHandler::register($debug) outside the debug check

Additional Context

No response

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0