8000 [DependencyInjection] failed importing doctrine PHP configs in the prepend extension method with multiple bundles with a different connection name · Issue #57964 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content
8000

[DependencyInjection] failed importing doctrine PHP configs in the prepend extension method with multiple bundles with a different connection name #57964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jfsenechal opened this issue Aug 9, 2024 · 9 comments
Closed

[DependencyInjection] failed importing doctrine PHP configs in the prepend extension method with multiple bundles with a different connection name #57964

jfsenechal opened this issue Aug 9, 2024 · 9 comments
Labels
Bug DependencyInjection Status: Needs Review

Comments

@jfsenechal
Copy link

Symfony version(s) affected

7.1.3

Description

for each bundle I import my doctrine config like this

return static function (DoctrineConfig $doctrine) {
    $name = 'xx';
    $doctrine->dbal()
        ->connection($name)
        ->url(env('DATABASE_URL_B')->resolve());

    $em = $doctrine->orm()->entityManager($name);
    $em->connection($name);

    $em->mapping('AcMarcheB')
        ->isBundle(false)
        ->type('attribute')
        ->dir('%kernel.project_dir%/src/AcMarche/B/src/Entity')
        ->prefix('AcMarche\B')
        ->alias('AcMarcheB');
};

if I use another connection name only the last config of the bundle is taken into account

How to reproduce

Sample with a bundle named A and an other named B

Disable auto config

//config/packages/doctrine.yaml
doctrine:
    dbal:
        ...
    orm:
        ...
        auto_mapping: false

Use the patch #57937 who fixed a first problem

Importing config

ABundle

class ABundle extends AbstractBundle
{
    public function getPath(): string
    {
        return \dirname(__DIR__);
    }

    public function loadExtension(array $config, ContainerConfigurator $container, ContainerBuilder $builder): void
    {
        $container->import('../config/services.php');
    }

    public function prependExtension(ContainerConfigurator $container, ContainerBuilder $builder): void
    {
        $container->import('../config/packages/doctrine.php');
    }
}
//doctrine.php
return static function (DoctrineConfig $doctrine) {
$name = 'default'
    $doctrine->dbal()
        ->connection($name)
        ->url(env('DATABASE_URL')->resolve());
    $em = $doctrine->orm()->entityManager($name);
    $em->connection($name);

    $em->mapping('AcMarcheBottin')
        ->isBundle(false)
        ->type('attribute')
        ->dir('%kernel.project_dir%/src/AcMarche/Bottin/src/Entity')
        ->prefix('AcMarche\Bottin')
        ->alias('AcMarcheBottin');
};

BBundle

class ABundle extends AbstractBundle
{
//...
//the same as above
}
//doctrine.php
return static function (DoctrineConfig $doctrine) {
$name="default"
    $doctrine->dbal()
        ->connection($name)
        ->url(env('DATABASE_URL_CAP')->resolve());

    $em = $doctrine->orm()->entityManager($name);
    $em->connection($name);

    $em->mapping('AcMarcheCap')
        ->isBundle(false)
        ->type('attribute')
        ->dir('%kernel.project_dir%/src/AcMarche/Cap/src/Entity')
        ->prefix('AcMarche\Cap')
        ->alias('AcMarcheCap');
};

Result With the same name "default"

bin/console doctrine:mapping:info 
 Found 2 mapped entities:

 [OK]   AcMarche\B\Entity\Article
 [OK]   AcMarche\A\Entity\Article

If I change name for A

//doctrine.php
return static function (DoctrineConfig $doctrine) {
$name = 'xxx'

Only entities in B are mapping

bin/console doctrine:mapping:info 
 Found 1 mapped entities:

 [OK]   AcMarche\B\Entity\Article

The same if I change connection name in B bundle

Possible Solution

No response

Additional Context

No response
@jfsenechal jfsenechal added the Bug label Aug 9, 2024
@jfsenechal jfsenechal changed the title [DependencyInjection] failed importing doctrine PHP configs in the prepend extension method with multiple bundles with a different same name connection [DependencyInjection] failed importing doctrine PHP configs in the prepend extension method with multiple bundles with a different name connection Aug 9, 2024
@jfsenechal jfsenechal changed the title [DependencyInjection] failed importing doctrine PHP configs in the prepend extension method with multiple bundles with a different name connection [DependencyInjection] failed importing doctrine PHP configs in the prepend extension method with multiple bundles with a different connection name Aug 9, 2024
@yceruto
Copy link
Member
yceruto commented Aug 9, 2024

I couldn’t reproduce your issue after applying this fix: #57937. It hasn’t been released yet, but you can test it on the 7.1 dev branch

@yceruto
Copy link
Member
yceruto commented Aug 9, 2024

can you create a small app that reproduce the issue?

@jfsenechal
Copy link
Author

Yes

Here is https://github.com/jfsenechal/dibug

@xabbuh
Copy link
Member
xabbuh commented Aug 9, 2024

Your demo application uses version 7.1.3 of the DependencyInjection component which does not contain the patch. You need to update to the dev version of 7.1: composer update symfony/dependency-injection:^7.1.4@dev

@xabbuh xabbuh closed this as not planned Won't fix, can't repro, duplicate, stale Aug 9, 2024
@jfsenechal
Copy link
Author

I use it !
I patched manually
Please reopen i executed composer update symfony/dependency-injection:^7.1.4@dev
and the same problem occurs

@xabbuh xabbuh reopened this Aug 9, 2024
@yceruto
Copy link
Member
yceruto commented Aug 9, 2024 •
edited
Loading

@jfsenechal, if you place both bundles under the same default connection, you’ll get all mapped entities (proving that it's working). It’s not about the bundle merging strategy not working as expected. You’ll encounter the same issue if you move both doctrine.php files to the root config/packages/ directory without using bundles.

@yceruto
Copy link
Member
yceruto commented Aug 9, 2024

Btw, I just spotted that there is an em option for doctrine:mapping:info, so if you have multiple connections, you'll need to pass the right em value --em=cap and then you'll see the mapped entities under that connection

@yceruto
Copy link
Member
yceruto commented Aug 9, 2024

Closing as it's not a bug.

@yceruto yceruto closed this as not planned Won't fix, can't repro, duplicate, stale Aug 9, 2024
@jfsenechal
Copy link
Author

Yes you are right i don't use correctly command mapping info
Thanks a lot for your work
Bon week end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug DependencyInjection Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@xabbuh @yceruto @jfsenechal @carsonbot
0