[DependencyInjection] failed importing doctrine PHP configs in the prepend extension method with multiple bundles with a different connection name #57964

jfsenechal · 2024-08-09T12:35:18Z

Symfony version(s) affected

7.1.3

Description

for each bundle I import my doctrine config like this

return static function (DoctrineConfig $doctrine) {
    $name = 'xx';
    $doctrine->dbal()
        ->connection($name)
        ->url(env('DATABASE_URL_B')->resolve());

    $em = $doctrine->orm()->entityManager($name);
    $em->connection($name);

    $em->mapping('AcMarcheB')
        ->isBundle(false)
        ->type('attribute')
        ->dir('%kernel.project_dir%/src/AcMarche/B/src/Entity')
        ->prefix('AcMarche\B')
        ->alias('AcMarcheB');
};

if I use another connection name only the last config of the bundle is taken into account

How to reproduce

Sample with a bundle named A and an other named B

Disable auto config

//config/packages/doctrine.yaml
doctrine:
    dbal:
        ...
    orm:
        ...
        auto_mapping: false

Use the patch #57937 who fixed a first problem

Importing config

ABundle

class ABundle extends AbstractBundle
{
    public function getPath(): string
    {
        return \dirname(__DIR__);
    }

    public function loadExtension(array $config, ContainerConfigurator $container, ContainerBuilder $builder): void
    {
        $container->import('../config/services.php');
    }

    public function prependExtension(ContainerConfigurator $container, ContainerBuilder $builder): void
    {
        $container->import('../config/packages/doctrine.php');
    }
}

//doctrine.php
return static function (DoctrineConfig $doctrine) {
$name = 'default'
    $doctrine->dbal()
        ->connection($name)
        ->url(env('DATABASE_URL')->resolve());
    $em = $doctrine->orm()->entityManager($name);
    $em->connection($name);

    $em->mapping('AcMarcheBottin')
        ->isBundle(false)
        ->type('attribute')
        ->dir('%kernel.project_dir%/src/AcMarche/Bottin/src/Entity')
        ->prefix('AcMarche\Bottin')
        ->alias('AcMarcheBottin');
};

BBundle

class ABundle extends AbstractBundle
{
//...
//the same as above
}

//doctrine.php
return static function (DoctrineConfig $doctrine) {
$name="default"
    $doctrine->dbal()
        ->connection($name)
        ->url(env('DATABASE_URL_CAP')->resolve());

    $em = $doctrine->orm()->entityManager($name);
    $em->connection($name);

    $em->mapping('AcMarcheCap')
        ->isBundle(false)
        ->type('attribute')
        ->dir('%kernel.project_dir%/src/AcMarche/Cap/src/Entity')
        ->prefix('AcMarche\Cap')
        ->alias('AcMarcheCap');
};

Result With the same name "default"

bin/console doctrine:mapping:info 
 Found 2 mapped entities:

 [OK]   AcMarche\B\Entity\Article
 [OK]   AcMarche\A\Entity\Article

If I change name for A

//doctrine.php
return static function (DoctrineConfig $doctrine) {
$name = 'xxx'

Only entities in B are mapping

bin/console doctrine:mapping:info 
 Found 1 mapped entities:

 [OK]   AcMarche\B\Entity\Article

The same if I change connection name in B bundle

Possible Solution

No response

Additional Context

No response

yceruto · 2024-08-09T12:47:44Z

I couldn’t reproduce your issue after applying this fix: #57937. It hasn’t been released yet, but you can test it on the 7.1 dev branch

yceruto · 2024-08-09T12:49:16Z

can you create a small app that reproduce the issue?

jfsenechal · 2024-08-09T12:55:57Z

Yes

Here is https://github.com/jfsenechal/dibug

xabbuh · 2024-08-09T13:38:42Z

Your demo application uses version 7.1.3 of the DependencyInjection component which does not contain the patch. You need to update to the dev version of 7.1: composer update symfony/dependency-injection:^7.1.4@dev

jfsenechal · 2024-08-09T13:49:20Z

I use it !
I patched manually
Please reopen i executed composer update symfony/dependency-injection:^7.1.4@dev
and the same problem occurs

yceruto · 2024-08-09T14:02:48Z

@jfsenechal, if you place both bundles under the same default connection, you’ll get all mapped entities (proving that it's working). It’s not about the bundle merging strategy not working as expected. You’ll encounter the same issue if you move both doctrine.php files to the root config/packages/ directory without using bundles.

yceruto · 2024-08-09T14:09:24Z

yceruto commented

Aug 9, 2024

Btw, I just spotted that there is an em option for doctrine:mapping:info, so if you have multiple connections, you'll need to pass the right em value --em=cap and then you'll see the mapped entities under that connection

yceruto · 2024-08-09T14:10:14Z

Closing as it's not a bug.

jfsenechal · 2024-08-09T14:40:39Z

Yes you are right i don't use correctly command mapping info
Thanks a lot for your work
Bon week end

jfsenechal added the Bug label Aug 9, 2024

carsonbot added Status: Needs Review DependencyInjection labels Aug 9, 2024

xabbuh closed this as not planned Won't fix, can't repro, duplicate, stale Aug 9, 2024

xabbuh reopened this Aug 9, 2024

yceruto closed this as not planned Won't fix, can't repro, duplicate, stale Aug 9, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

[DependencyInjection] failed importing doctrine PHP configs in the prepend extension method with multiple bundles with a different connection name #57964

[DependencyInjection] failed importing doctrine PHP configs in the prepend extension method with multiple bundles with a different connection name #57964

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

[DependencyInjection] failed importing doctrine PHP configs in the prepend extension method with multiple bundles with a different connection name #57964

[DependencyInjection] failed importing doctrine PHP configs in the prepend extension method with multiple bundles with a different connection name #57964

Comments

Symfony version(s) affected

Description

How to reproduce

Importing config

Possible Solution

Additional Context

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!