8000 Move or retire UserInterface::eraseCredentials · Issue #57842 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Move or retire UserInterface::eraseCredentials #57842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the c 8000 ommunity.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dbrumann opened this issue Jul 26, 2024 · 2 comments · Fixed by #59682
Closed

Move or retire UserInterface::eraseCredentials #57842

dbrumann opened this issue Jul 26, 2024 · 2 comments · Fixed by #59682
Labels
RFC RFC = Request For Comments (proposals about features that you want to be discussed) Security

Comments

@dbrumann
Copy link
Contributor

Description

This comes a bit out of the blue and I am not sure how relevant it is or if it was asked before (at least I couldn't find any issues after a quick search). I am setting up a new demo project and having to implement an empty UserInterface::eraseCredentials irked me a bit.

Essentially, it seems misplaced to me after moving getPassword out and possibly even no longer relevant although that might be specific to how I use the security system. In any case, we have the same method eraseCredentials both on the UserInterface and TokenInterface and quite often - even in the examples in the docs nowadays - it is just kept empty. I suggest deprecating both and moving them to a new dedicated, optional interface. Before starting the hardest task of finding a name for that new interface I wanted to ask if it is even worth the effort.

Should eraseCredentials from UserInterface and TokenInterface be merged into its own dedicated interface?

Example

No response
@derrabus derrabus added Security RFC RFC = Request For Comments (proposals about features that you want to be discussed) labels Jul 26, 2024
@chalasr
Copy link
Member
chalasr commented Aug 4, 2024

Sounds good to me. Good luck finding the name :)

@chalasr chalasr mentioned this issue Dec 6, 2024
Closed
@chalasr
Copy link
Member
chalasr commented Dec 6, 2024

See #59106

@nicolas-grekas nicolas-grekas mentioned this issue Feb 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
RFC RFC = Request For Comments (proposals about features that you want to be discussed) Security
Projects
None yet
Milestone
No milestone
3 participants
@derrabus @dbrumann @chalasr
0