[Security][Framework] Use Firewall Settings to get UserProvider Service for Request #54713

Hanmac · 2024-04-24T08:42:29Z

Description

#46066 Allows to get the Firewall Config for a given Request, but the UserProvider is a string and doesn't give me the Service instance.

What I want, is to get the UserProvider (if able) for the current Firewall.
Either via a Service, or via RequestResolver.

Example:

I have a Controller like ForgetPassword.
I also have multiple Firewalls with different kind of Users, each should have their own ForgetPasswordAction
Instead of Writing multiple Controller Classes, I can just use Routing and have the same Controller under Multiple Routes
Now inside the Controller, I would like to access the UserProvider to give me the User I want to do my actions.
Depending on the Route, I'm in a different Firewall, so I get a different UserProvider with a different User type.

Example

No response

n0rbyt3 · 2024-05-05T08:48:27Z

Let your controller extend AbstractController, then call $this->getUser() to get the authenticated user if any.

Docs: https://symfony.com/doc/current/controller.html#the-base-controller-class-services

Hanmac · 2024-05-05T10:28:16Z

Let your controller extend AbstractController, then call $this->getUser() to get the authenticated user if any.

Docs: https://symfony.com/doc/current/controller.html#the-base-controller-class-services

The Feature I would like was to get the UserProviderService for the Current Firewall

Not the Current User

n0rbyt3 · 2024-05-05T10:42:41Z

Sorry, my bad. I found a note in the docs:

Sometimes, you need to inject the user provider in another class (e.g. in your custom authenticator). All user providers follow this pattern for their service ID: security.user.provider.concrete.<your-provider-name> (where <your-provider-name> is the configuration key, e.g. app_user_provider).

Source: https://symfony.com/doc/current/security.html#loading-the-user-the-user-provider

Hanmac · 2024-05-05T17:32:58Z

the Problem is still getting the right name/service

For Example A, if the firewall uses multiple Providers, the Firewall Service gets a Chained Provider
Using The Firewall Configuration, i can get the names of the providers, and so their Service Id, but i wouldn't get the Service for the Chained one (that is not that bad imo)

===

Hm i think i found the Service I was looking for: security.user_providers
This one should hold all the UserProvider using their specific ids

n0rbyt3 · 2024-05-05T17:56:17Z

That clarifies a bit more. So you don't want to get the UserProviderInterface service, you want to get inside the internal implementation. And that is impossible.

Your code should not rely on the implementation, but use the interface method it provides.

Let's say you have two firewalls:

"main" that uses a chained provider "chained" which holds provider "in_memory" and "entity" internally
"admin" that uses "ldap" provider directly

You can get access to "chained" or "ldap" by referencing the service, but you cannot determine that "chained" used "entity" internally. Just re-use "chained" as-it and let it iterate through the internal user providers again.

Also I don't see a use-case where you have to use different user providers for different firewalls and cannot rely on chained provider to search for other users.

You may create your own implementation that acts like a chained provider, returns a wrapped UserInterface which holds the source UserProviderInterface service id.

Hanmac · 2024-05-05T19:12:49Z

@n0rbyt3 my goal:

have some UserProvider implement my interface, for example ResetPasswordUserProviderInterface

then i can use the Firewall Config + the security.user_providers service to get the UserProvider
then i can check if that UserProvider does implement my Interface
if it does, then for example, i can call requestPasswordReset and make a new PasswordReset for the given user in that firewall

You can get access to "chained" or "ldap" by referencing the service, but you cannot determine that "chained" used "entity" internally. Just re-use "chained" as-it and let it iterate through the internal user providers again.

that is the problem i am seeing right now, that i don't have a way to access the Chained Provider?
and even if i could, it wouldn't implement my Interface (unless i decorate it?)

Also I don't see a use-case where you have to use different user providers for different firewalls and cannot rely on chained provider to search for other users.

I may not rely on loadUserByIdentifier from the UserProviderInterface

My main Idea was not to have something that can be generated via something like the MakerBundle, but have the router/firewall handle the problem.

example:
/reset-password would detect that it is in the frontend firewall and uses the frontend UserProvider to find the right users
/admin/reset-password then it would detect the admin firewall, and uses the admin UserProvider

carsonbot · 2024-11-06T13:03:42Z

Thank you for this suggestion.
There has not been a lot of activity here for a while. Would you still like to see this feature?
Every feature is developed by the community.
Perhaps someone would like to try?
You can read how to contribute to get started.

carsonbot · 2024-11-20T13:05:58Z

Friendly reminder that this issue exists. If I don't hear anything I'll close this.

Hanmac · 2024-11-24T08:02:42Z

i would still like to do that feature

my main goal would be to not need to create a Controller for each of my firewalls,
but reuse the same Controller with multiple Routes inside each Firewall

carsonbot added the Security label Apr 24, 2024

xabbuh added the Feature label Apr 24, 2024

Hanmac mentioned this issue May 5, 2024

Multiple entities SymfonyCasts/reset-password-bundle#110

Open

carsonbot added the Stalled label Nov 6, 2024

carsonbot removed the Stalled label Nov 24, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security][Framework] Use Firewall Settings to get UserProvider Service for Request #54713

[Security][Framework] Use Firewall Settings to get UserProvider Service for Request #54713

[Security][Framework] Use Firewall Settings to get UserProvider Service for Request #54713

[Security][Framework] Use Firewall Settings to get UserProvider Service for Request #54713

Comments

Description

Example