[RFC] DkimSigner (and SMimeSigner & Encrypter) return type #53939
Comments
|
Thank you for this suggestion. |
|
Hello? This issue is about to be closed if nobody replies. |
|
Hey, I didn't hear anything so I'm going to close it. Feel free to comment if this is still relevant, I can always reopen! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
I'm new to (DKIM)signing emails, and have a couple, of observations/suggestions that might make the process easier to work with.
The
DkimSigner'ssign()method (andSMimeSigner'ssign()method &SMimeEncrypter'sencrypt()method, though I haven't used those) returns aSymfony\Component\Mime\Messagebut this can cause a problem when used to sign an object type that extends thatMessageclass.My specific problem was #53928 (Web profiler "Emails" tab breaks with signed emails) but I suppose other things might need to get the same object type back from the method as they passed to it) because the profiler was expecting an
Emailobject but got aMessageobject.Perhaps the PHP return type doesn't need changing, and the method logic could clone the passed
$messageand perform its operations on that clone, then return that clone? I'm not sure if PHP's return declarations are strict in that way, or whether it is allowed to return a class that extends the one in the return type.I also don't know if something absolutely needs those methods to return a
Messageand not some other object that extends it.Example
No response
The text was updated successfully, but these errors were encountered: