8000 [Messenger] RedisSentinel for messeger needs the same fix cache got in #51683 · Issue #52487 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Messenger] RedisSentinel for messeger needs the same fix cache got in #51683 #52487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dkarlovi opened this issue Nov 7, 2023 · 0 comments
Closed

[Messenger] RedisSentinel for messeger needs the same fix cache got in #51683 #52487

dkarlovi opened this issue Nov 7, 2023 · 0 comments
Labels
Bug Messenger Status: Needs Review

Comments

@dkarlovi
Copy link
Contributor
dkarlovi commented Nov 7, 2023

Symfony version(s) affected

6.3.5

Description

Same problem as in #51683.

How to reproduce

Use redis-messenger with Sentinel, you get

RedisSentinel::__construct() expects at most 1 argument, 6 given

Possible Solution

Same type as #51683.

Additional Context

No response
@dkarlovi dkarlovi added the Bug label Nov 7, 2023
This was referenced Nov 17, 2023
Closed
Merged
nicolas-grekas added a commit that referenced this issue Nov 21, 2023
@nicolas-grekas
bug #52629 [Messenger] Fix support for Redis Sentinel using php-redis…
43a1fa1 
… 6.0.0 (pepeh)

This PR was squashed before being merged into the 6.3 branch.

Discussion
----------

[Messenger] Fix support for Redis Sentinel using php-redis 6.0.0

| Q             | A
| ------------- | ---
| Branch?       | 6.3
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Issues        | Fix #52487
| License       | MIT

Added support for [php-redis 6.0.0](https://github.com/phpredis/phpredis/blob/develop/CHANGELOG.md#600---2023-09-09-github-pecl) to Symfony/Component/Messenger/Bridge/Redis/Transport/Connection.
A similar fix was done for RedisTrait before: #51683

Commits
-------

42a80db [Messenger] Fix support for Redis Sentinel using php-redis 6.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Messenger Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dkarlovi @nicolas-grekas @carsonbot
0