[Messenger] Make HandleTrait unwrap HandlerFailedException
#52300
Labels
Comments
|
In our bus which we use we are also doing it via a middleware: https://github.com/sulu/messenger#unpackexceptionmiddleware, as that make it possible to catch our domain exception in the controllers/commands. |
|
Such a middleware would allow to keep the BC, so… I hope you don’t mind but I’m stealing the idea 😁 |
This was referenced Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
The
HandleTraitallows to use Messenger as a function call by enforcing a single handler being called and returning its result (cf. https://symfony.com/doc/current/messenger.html#getting-results-when-working-with-command-query-buses).Still, if this handler throws an exception it will be wrapped in a
HandlerFailedException. The latter is useful when multiple handlers are called, but it seems to me it just adds noise when using theHandleTrait.Would it make sense to make
HandleTrait::handlecatchHandlerFailedExceptions and throw the wrapped exception instead?Example
No response
The text was updated successfully, but these errors were encountered: