8000 symfony/mailgun-mailer should require symfony/http-client · Issue #50598 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

symfony/mailgun-mailer should require symfony/http-client #50598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
FlorianMoser opened this issue Jun 8, 2023 · 4 comments
Closed

symfony/mailgun-mailer should require symfony/http-client #50598

FlorianMoser opened this issue Jun 8, 2023 · 4 comments

Comments

@FlorianMoser
Copy link

Symfony version(s) affected

6.3.0

Description

symfony/mailgun-mailer has a dependency on symfony/http-client, but symfony/http-client is only present as "require-dev".

How to reproduce

Require symfony/mailgun-mailer in a project that doesn't use symfony/http-client.

Possible Solution

Move the symfony/http-client dependency from "require-dev" to "require" in the composer.json file.

Additional Context

We used symfony/mailgun-mailer in a Laravel installation. After upgrading Laravel (and no longer using symfony/http-client), form submission were no longer mailed. An issue that was only discovered after 2 month and caused severe troubles for our client.

It should be an easy fix for a quite severe problem (in some cases).

@derrabus
Copy link
Member
derrabus commented Jun 8, 2023

You don't need the HTTP client if you interface with mailgun via SMTP. That's why it's optional.

Maybe this should be documented better.

@derrabus
Copy link
Member
derrabus commented Jun 8, 2023

I've filed symfony/symfony-docs#18386 for that matter.

@xabbuh
Copy link
Member
xabbuh commented Jun 8, 2023

closing in favour of symfony/symfony-docs#18386 then

@xabbuh xabbuh closed this as not planned Won't fix, can't repro, duplicate, stale Jun 8, 2023
@FlorianMoser
Copy link
Author

I see, that makes sense.

Thanks @derrabus !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants
0