8000 Why `fake-sms-notifier` factory requires MailerInterface when this feature is not required? · Issue #48441 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content
8000
Why fake-sms-notifier factory requires MailerInterface when this feature is not required? #48441
New issue
New issue
Closed
#48546
Closed
Why fake-sms-notifier factory requires MailerInterface when this feature is not required?#48441
#48546
Labels
Help wantedIssues and PRs which are looking for volunteers to complete them.Notifier
@roquie

Description

@roquie
roquie
opened on Dec 2, 2022

Description

https://github.com/symfony/fake-sms-notifier/blob/6.2/FakeSmsTransportFactory.php#L30

If I want to use only fakesms+logger dsn why I should install mailer or implement fake class for it?

My suggestions:

  1. BC: replace MailerInterface with LoggerInterface and make $mailer null by default and ? sign
  2. Non-BC: Add a ? sign before MailerInterface

Example

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    Help wantedIssues and PRs which are looking for volunteers to complete them.Notifier

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions
      0