10000 [Twig Bridge] main.css contains URL to githubusercontent.com being flagged as Malicious by VirusTotal.com · Issue #47454 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[Twig Bridge] main.css contains URL to githubusercontent.com being flagged as Malicious by VirusTotal.com #47454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
d42ohpaz opened this issue Sep 1, 2022 · 4 comments

Comments

@d42ohpaz
Copy link
d42ohpaz commented Sep 1, 2022

Symfony version(s) affected

v5.4.8

Description

When generating emails using twig-bridge, the main.css contains the following link, which is hosted on a domain that is considered malicious by CMC Threat Intelligence. This is causing emails to be mistakenly quarantined and not delivered to the end users.

The URL in question is https://raw.githubusercontent.com/foundation/foundation-emails/v2.2.1/dist/foundation-emails.css.

How to reproduce

If you go to https://www.virustotal.com/gui/url/cfee0ef7cfca28ccb91d3df257c043b45b23556c288d203d165d429811a1031f you will see that CMC Threat Intelligence does flag this as malicious. You will need to go to https://www.virustotal.com/gui/url/dce9ba69237bcd0d3c424e56b4d5126d3d8b35ee1d7d4d60fea7efb71efde92a/community to understand that it is flagged malicious to being a repository of virus information.

Possible Solution

One way to resolve this issue is to remove the comment with the license information and the URL, and put it in a separate file that does not make its way into the email source code.

Additional Context

I have also contacted CMC Threat Intelligence asking for them to remove the flag on githubusercontent, but I suspect not much will come from that.

@stof
Copy link
Member
stof commented Sep 2, 2022

How is this main.css file built ?

@stof
Copy link
Member
stof commented Sep 2, 2022

ah, we have it directly in our source. I suggest we remove the URL from the license header, putting the exact link for the source somewhere else (in the readme or in an associated file)

@carsonbot
Copy link

Hey, thanks for your report!
There has not been a lot of activity here for a while. Is this bug still relevant? Have you managed to find a workaround?

@alamirault
Copy link
Contributor

Thanks @carsonbot, I created a relative PR #49602

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants
0