10000 dependency-injection - Spaces in system temp folder path cause deprecation errors in php 8 about libxml_disable_entity_loader · Issue #46799 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content
8000

dependency-injection - Spaces in system temp folder path cause deprecation errors in php 8 about libxml_disable_entity_loader #46799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
demeritcowboy opened this issue Jun 29, 2022 · 1 comment
Closed

dependency-injection - Spaces in system temp folder path cause deprecation errors in php 8 about libxml_disable_entity_loader #46799

demeritcowboy opened this issue Jun 29, 2022 · 1 comment
Labels
Bug DependencyInjection Status: Needs Review

Comments

@demeritcowboy
Copy link
Contributor
demeritcowboy commented Jun 29, 2022 •
edited
Loading

Symfony version(s) affected

4.4+

Description

In https://github.com/symfony/dependency-injection/blob/ffaa7b47a728b8a644ced7dce6e3f7b89b1c06bb/Loader/XmlFileLoader.php#L686, it creates a file:// url that isn't url-encoded. This causes shouldEnableEntityLoader() to return true in php 8 instead of false when e.g. the temp folder path contains spaces.

How to reproduce

  1. If you have a local windows dev setup, the temp folder path might be something like C:\Users\Your Name\AppData\Local\Temp. If you don't have that or control over the system temp folder path, then you can temporarily edit https://github.com/symfony/dependency-injection/blob/ffaa7b47a728b8a644ced7dce6e3f7b89b1c06bb/Loader/XmlFileLoader.php#L680 to set $tmpfile to a path that you know exists and has spaces.
  2. Make a little file x.xml like this: 
    <container xmlns="http://symfony.com/schema/dic/services"
       xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
       xsi:schemaLocation="http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd">
  <services>
  </services>
</container>
  3. Make a little php file like this: 
    <?php
require_once 'vendor/autoload.php';
$containerBuilder = new \Symfony\Component\DependencyInjection\ContainerBuilder();
$loader = new \Symfony\Component\DependencyInjection\Loader\XmlFileLoader($containerBuilder, new \Symfony\Component\Config\FileLocator(__DIR__));
$loader->load('x.xml');
  4. Using php8, run your php file.
  5. PHP Deprecated: Function libxml_disable_entity_loader() is deprecated in ...\vendor\symfony\dependency-injection\Loader\XmlFileLoader.php

Possible Solution

Patch to https://github.com/symfony/dependency-injection/blob/ffaa7b47a728b8a644ced7dce6e3f7b89b1c06bb/Loader/XmlFileLoader.php#L686:

-<xsd:include schemaLocation="file:///'.str_replace('\\', '/', $tmpfile).'" />';
+<xsd:include schemaLocation="file:///'.rawurlencode(str_replace('\\', '/', $tmpfile)).'" />';

Additional Context

I admit I haven't run it against 6.x. Where this came up in real life was in a 3rd party web app that uses version 4.4 of symfony/dependency-injection, but the code is the same as 6.x.
@demeritcowboy demeritcowboy mentioned this issue Jun 29, 2022
Merged
@demeritcowboy
Copy link
Contributor Author

Added PR at #46800

nicolas-grekas added a commit that referenced this issue Jun 29, 2022
@nicolas-grekas
bug #46800 Spaces in system temp folder path cause deprecation errors…
2c26d24 
… in php 8 (demeritcowboy)

This PR was merged into the 4.4 branch.

Discussion
----------

Spaces in system temp folder path cause deprecation errors in php 8

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #46799
| License       | MIT
| Doc PR        |

See #46799

Commits
-------

2ac82ac Spaces in system temp folder path cause deprecation errors in php 8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug DependencyInjection Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@nicolas-grekas @xabbuh @demeritcowboy @carsonbot
0