Symfony not working on SMB #45990

qinshuze · 2022-04-11T07:53:03Z

Symfony version(s) affected

6

Description

Hi I am using Symfony 6 and PHP 8.1.4
I share the project over SMB on Windows and mount the project on Linux, but I run into a problem when running the project, accessing the project keeps waiting until it times out; this only happens on SMB shared directories, running locally when everything works.
How can I get the project to work properly on an SMB shared folder?
English is not my native language; please excuse typing errors.

How to reproduce

Share the project folder via SMB on Windows10, mount the shared folder in Linux (Debian11) and run it
Mount command: mount -o uid=1000,gid=1000,username=qsz,password=123456,rsize=1048576,wsize=1048576 -t cifs //192.1 68.100.1/Web/mnt/web/

Possible Solution

After investigation, it is found that when the program executes this code under the vendor\symfony\http-kernel\Kernel.php file, it will always get stuck

Try adding flock($lock, \LOCK_UN); before if (!flock($lock, $wouldBlock ? \LOCK_SH : \LOCK_EX)) { and the program works fine

Additional Context

No response

The text was updated successfully, but these errors were encountered:

nicolas-grekas · 2022-04-12T07:13:51Z

Can you try this patch? Does it work around the issue on SMB?

--- a/src/Symfony/Component/HttpKernel/Kernel.php
+++ b/src/Symfony/Component/HttpKernel/Kernel.php
@@ -528,9 +528,7 @@ abstract class Kernel implements KernelInterface, RebootableInterface, Terminabl
             is_dir($cacheDir) ?: mkdir($cacheDir, 0777, true);
 
             if ($lock = fopen($cachePath.'.lock', 'w')) {
-                flock($lock, \LOCK_EX | \LOCK_NB, $wouldBlock);
-
-                if (!flock($lock, $wouldBlock ? \LOCK_SH : \LOCK_EX)) {
+                if (!flock($lock, \LOCK_EX | \LOCK_NB, $wouldBlock) && !flock($lock, $wouldBlock ? \LOCK_SH : \LOCK_EX)) {
                     fclose($lock);
                     $lock = null;
                 } elseif (!is_file($cachePath) || !\is_object($this->container = include $cachePath)) {

nicolas-grekas · 2022-04-12T07:14:51Z

(please send a PR on branch 4.4 if that works)

qinshuze · 2022-04-12T07:35:02Z

Yes this solves my problem with SMB

Can you try this patch? Does it work around the issue on SMB?

--- a/src/Symfony/Component/HttpKernel/Kernel.php 
+++ b/src/Symfony/Component/HttpKernel/Kernel.php 
@@ -528,9 +528,7 @@ abstract class Kernel implements KernelInterface, RebootableInterface, Terminabl
             is_dir($cacheDir) ?: mkdir($cacheDir, 0777, true);
 
             if ($lock = fopen($cachePath.'.lock', 'w')) {
-                flock($lock, \LOCK_EX | \LOCK_NB, $wouldBlock);
- 
-                 if (!flock($lock, $wouldBlock ? \LOCK_SH : \LOCK_EX)) { 
+                 if (!flock($lock, \LOCK_EX | \LOCK_NB, $wouldBlock) && !flock($lock, $wouldBlock ? \ LOCK_SH : \LOCK_EX)) {
                     fclose($lock);
                     $lock = null;
                 } elseif (!is_file($cachePath) || !\is_object($this->container = include $cachePath)) {

This PR was merged into the 4.4 branch. Discussion ---------- [HttpKernel] Fix Symfony not working on SMB share | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | #45990 | License | MIT | Doc PR | - Commits ------- 1ff7ebc Fix Symfony not working on SMB share #45990

* 4.4: [Workflow] Catch error when trying to get an uninitialized marking Add missing license header Use reference date in reverse transform Fixes #40997 Fix env resolution in lock configuration Fix Symfony not working on SMB share #45990 [Cache] make LockRegistry use static properties instead of static variables fix: return-path has higher priority for envelope address than from address (fixes #41322) [HttpClient] Fix sending content-length when streaming the body [Console] Header with column max width is now well wrap with separator [DependencyInjection] Add TaggedIteratorArgument unit tests

* 5.4: (21 commits) Add missing license header [Workflow] Catch error when trying to get an uninitialized marking Add missing license header Allow usage of Provider domains if possible Use reference date in reverse transform Fixes #40997 Fix env resolution in lock configuration Fix Symfony not working on SMB share #45990 [Messenger] DoctrineTransportFactory works with notify and decorated PostgreSQL driver [Cache] make LockRegistry use static properties instead of static variables fix: return-path has higher priority for envelope address than from address (fixes #41322) [HttpClient] Fix sending content-length when streaming the body [Console] Header with column max width is now well wrap with separator Fix use_cookies framework session configuration [FrameworkBundle] [Command] Fix `debug:router --no-interaction` error … [Intl] Update the ICU data to 71.1 - 5.4 [Intl] Update the ICU data to 71.1 - 4.4 Add tests to messenger connection get for OraclePlatform [RateLimiter] Adding default empty value [DependencyInjection] Add TaggedIteratorArgument unit tests [Process] Fix Process::getEnv() when setEnv() hasn't been called before ...

* 6.0: (22 commits) Add missing license header Add missing license header [Workflow] Catch error when trying to get an uninitialized marking Add missing license header Allow usage of Provider domains if possible Use reference date in reverse transform Fixes #40997 Fix env resolution in lock configuration Fix Symfony not working on SMB share #45990 [Messenger] DoctrineTransportFactory works with notify and decorated PostgreSQL driver [Cache] make LockRegistry use static properties instead of static variables fix: return-path has higher priority for envelope address than from address (fixes #41322) [HttpClient] Fix sending content-length when streaming the body [Console] Header with column max width is now well wrap with separator Fix use_cookies framework session configuration [FrameworkBundle] [Command] Fix `debug:router --no-interaction` error … [Intl] Update the ICU data to 71.1 - 5.4 [Intl] Update the ICU data to 71.1 - 4.4 Add tests to messenger connection get for OraclePlatform [RateLimiter] Adding default empty value [DependencyInjection] Add TaggedIteratorArgument unit tests ...

* 4.4: [Workflow] Catch error when trying to get an uninitialized marking Add missing license header Use reference date in reverse transform Fixes symfony#40997 Fix env resolution in lock configuration Fix Symfony not working on SMB share symfony#45990 [Cache] make LockRegistry use static properties instead of static variables fix: return-path has higher priority for envelope address than from address (fixes symfony#41322) [HttpClient] Fix sending content-length when streaming the body [Console] Header with column max width is now well wrap with separator [DependencyInjection] Add TaggedIteratorArgument unit tests

* 5.4: (21 commits) Add missing license header [Workflow] Catch error when trying to get an uninitialized marking Add missing license header Allow usage of Provider domains if possible Use reference date in reverse transform Fixes symfony#40997 Fix env resolution in lock configuration Fix Symfony not working on SMB share symfony#45990 [Messenger] DoctrineTransportFactory works with notify and decorated PostgreSQL driver [Cache] make LockRegistry use static properties instead of static variables fix: return-path has higher priority for envelope address than from address (fixes symfony#41322) [HttpClient] Fix sending content-length when streaming the body [Console] Header with column max width is now well wrap with separator Fix use_cookies framework session configuration [FrameworkBundle] [Command] Fix `debug:router --no-interaction` error … [Intl] Update the ICU data to 71.1 - 5.4 [Intl] Update the ICU data to 71.1 - 4.4 Add tests to messenger connection get for OraclePlatform [RateLimiter] Adding default empty value [DependencyInjection] Add TaggedIteratorArgument unit tests [Process] Fix Process::getEnv() when setEnv() hasn't been called before ...

* 6.0: (22 commits) Add missing license header Add missing license header [Workflow] Catch error when trying to get an uninitialized marking Add missing license header Allow usage of Provider domains if possible Use reference date in reverse transform Fixes symfony#40997 Fix env resolution in lock configuration Fix Symfony not working on SMB share symfony#45990 [Messenger] DoctrineTransportFactory works with notify and decorated PostgreSQL driver [Cache] make LockRegistry use static properties instead of static variables fix: return-path has higher priority for envelope address than from address (fixes symfony#41322) [HttpClient] Fix sending content-length when streaming the body [Console] Header with column max width is now well wrap with separator Fix use_cookies framework session configuration [FrameworkBundle] [Command] Fix `debug:router --no-interaction` error … [Intl] Update the ICU data to 71.1 - 5.4 [Intl] Update the ICU data to 71.1 - 4.4 Add tests to messenger connection get for OraclePlatform [RateLimiter] Adding default empty value [DependencyInjection] Add TaggedIteratorArgument unit tests ...

qinshuze added the Bug label Apr 11, 2022

carsonbot added the Status: Needs Review label Apr 11, 2022

xabbuh added the HttpKernel label Apr 11, 2022

qinshuze added a commit to qinshuze/symfony that referenced this issue Apr 12, 2022

Fix Symfony not working on SMB share symfony#45990

1ff7ebc

nicolas-grekas mentioned this issue Apr 12, 2022

[HttpKernel] Fix Symfony not working on SMB share #46012

Merged

nicolas-grekas closed this as completed Apr 12, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Symfony not working on SMB #45990

Symfony not working on SMB #45990

Symfony not working on SMB #45990

Symfony not working on SMB #45990

Comments

Symfony version(s) affected

Description

How to reproduce

Possible Solution

Additional Context