8000 [DependencyInjection] ParameterBag signature changed in a patch version · Issue #45707 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[DependencyInjection] ParameterBag signature changed in a patch version #45707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
BafS opened this issue Mar 10, 2022 · 4 comments
Closed

[DependencyInjection] ParameterBag signature changed in a patch version #45707

BafS opened this issue Mar 10, 2022 · 4 comments
Labels
Bug DependencyInjection Status: Needs Review

Comments

@BafS
Copy link
Contributor
BafS commented Mar 10, 2022

Symfony version(s) affected

6.0.5

Description

The signature of ParameterBag changed in version 6.0.5 (\UnitEnum).

We are extending EnvPlaceholderParameterBag and ParameterBag (since the classes are not marked final) but the signature of some methods changed in a patch version which is a breaking change. Apparently it was introduced in #44868.

See: symfony/dependency-injection@v6.0.3...v6.0.5

How to reproduce

Extends "ParameterBag#set" using symfony/dependency-injection v6.0.0, update to v6.0.5 and it will break.

Possible Solution

Use the phpdoc to have the updated signature.

Additional Context

No response
@BafS BafS added the Bug label Mar 10, 2022
@carsonbot
Copy link

Hey, thanks for your report!
There has not been a lot of activity here for a while. Is this bug still relevant? Have you managed to find a workaround?

@BafS
Copy link
Contributor Author
BafS commented Sep 12, 2022

It is still relevant but now it's probably too late, it definitely broke the backward compatibility promise.

@carsonbot carsonbot removed the Stalled label Sep 12, 2022
@derrabus
Copy link
Member

You are right, unfortunately a BC break was introduced here. However, fixing it now (essentially by reverting the change) would probably do more harm than good. Let's close as won't fix?

@BafS
Copy link
Contributor Author
BafS commented Sep 12, 2022

All right, let's close it

@BafS BafS closed this as completed Sep 12, 2022
@derrabus derrabus closed this as not planned Won't fix, can't repro, duplicate, stale Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug DependencyInjection Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@BafS @derrabus @carsonbot
0