8000 [Mime] Improve or document `In-Reply-To` and `References` headers · Issue #45097 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Mime] Improve or document In-Reply-To and References headers #45097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ThomasLandauer opened this issue Jan 20, 2022 · 2 comments · Fixed by #47225
Closed

[Mime] Improve or document In-Reply-To and References headers #45097

ThomasLandauer opened this issue Jan 20, 2022 · 2 comments · Fixed by #47225
Labels
Mime

Comments

@ThomasLandauer
Copy link
Contributor

Description

As @micheh reports, since #44732 it's more complicated to add an In-Reply-To or References header, since you have to take care of the brackets <...> yourself, see #44732 (comment)

What do you think?

Example

No response
@carsonbot carsonbot added the Mime label Jan 20, 2022
@ThomasLandauer
Copy link
Contributor Author

Better idea if it's going to be the PR: Add an optional third argument bool $validate=true to addIdHeader()

@fabpot
Copy link
Member
fabpot commented Aug 5, 2022

@ThomasLandauer I think you can go with the validate argument on addIdHeader().

@AlbinoDrought AlbinoDrought mentioned this issue Aug 8, 2022
Merged
@fabpot fabpot closed this as completed Aug 10, 2022
fabpot added a commit that referenced this issue Aug 10, 2022
@fabpot
feature #47225 [Mime] Re-allow addIdHeader to be used for 'In-Reply-T…
14c4cd5 
…o' and 'References' headers (AlbinoDrought)

This PR was merged into the 6.2 branch.

Discussion
----------

[Mime] Re-allow addIdHeader to be used for 'In-Reply-To' and 'References' headers

| Q             | A
| ------------- | ---
| Branch?       | 6.2
| Bug fix?      | no (arguable: undo BC break)
| New feature?  | yes (arguable: undo BC break)
| Deprecations? | no
| Tickets       | Fix #45097
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

#44732 causes messages using `addIdHeader('In-Reply-To', ...)` or `addIdHeader('References', ...)` to fail the headers check (see #44732 (comment) ), requiring users to manually format the header value themselves.

This PR re-allows the previous behaviour of `addIdHeader` while keeping the new unstructured behaviour in-place as the default.

-----

(I'm not sure if this counts as a new feature or a bug fix since it "reintroduces" a previous feature)

Commits
-------

ffde0f1 [Mime] Re-allow addIdHeader to be used for 'In-Reply-To' and 'References' headers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Mime
Projects
None yet
Milestone
No milestone
3 participants
@fabpot @ThomasLandauer @carsonbot
0