Here is the code that I have promised. I decided to add a filters attribute instead of creating a whole new tag.
The xsd should be simple and gives room to add filters in the future.

@fabpot Could you please send me a link to the reasons for refusal. Tnx

Index: vendors/symfony/src/Symfony/Component/DependencyInjection/SimpleXMLElement.php
<+>UTF-8
===================================================================
--- vendors/symfony/src/Symfony/Component/DependencyInjection/SimpleXMLElement.php      (revision )
+++ vendors/symfony/src/Symfony/Component/DependencyInjection/SimpleXMLElement.php      (revision )
@@ -40,6 +40,7 @@
      */
     public function getArgumentsAsPhp($name, $lowercase = true)
     {
+        $filters = array();
         $arguments = array();
         foreach ($this->$name as $arg) {
             if (isset($arg['name'])) {
@@ -47,11 +48,20 @@
             }                                                                                                                                                                                                                    
             $key = isset($arg['key']) ? (string) $arg['key'] : (!$arguments ? 0 : max(array_keys($arguments)) + 1);                                                                                                              

+            if ('parameter' == $name) {                                                                                                                                                                                          
+              if ($lowercase) {                                                                                                                                                                                                  
-            // parameter keys are case insensitive                                                                                                                                                                               
+                // parameter keys are case insensitive                                                                                                                                                                           
-            if ('parameter' == $name && $lowercase) {                                                                                                                                                                            
                 $key = strtolower($key);                                                                                                                                                                                       
-            }                                                                                                                                                                                                                  
+              }                                                                                                                                                                                                                

+              if (isset($arg['filters'])) {                                                                                                                                                                                    
+                $parameterFilters = self::parseFilters($arg['filters']);                                                                                                                                                       
+                if (!empty($parameterFilters)) {                                                                                                                                                                               
+                  $filters[$key] = $parameterFilters;
+                }
+              }
+            }
+
             // this is used by DefinitionDecorator to overwrite a specific
             // argument of the parent definition
             if (isset($arg['index'])) {
@@ -89,6 +99,10 @@
             }
         }

+        foreach($filters as $key => $filter) {
+          $arguments[$key] = self::applyFilters($arguments[$key], $filter);
+        }
+
         return $arguments;
     }

@@ -123,5 +137,26 @@
             default:
                 return $value;
         }
+    }
+
+    static protected function parseFilters($definition) {
+      if (empty($definition)) {
+        return null;
+      }
+      $filters = array();
+      foreach(explode(',', $definition) as $def) {
+        switch ($def) {
+          case 't': $filters[] = 'trim'; break;
+          // TODO add what ever filter you wish to implement and code it the way you want
+        }
+      }
+      return $filters;
+    }
+
+    static protected  function applyFilters($value, $filters) {
+      foreach($filters as $filter) {
+        $value = call_user_func($filter, $value);
+      }
+      return $value;
     }
 }

Uh oh!

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions