8000 5.4.0: `SessionListener::onKernelResponse` listener is registered twice in test env · Issue #44345 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content
5.4.0: SessionListener::onKernelResponse listener is registered twice in test env #44345
Closed
@mhujer

Description

@mhujer

Symfony version(s) affected

5.4.0

Description

Symfony\Component\HttpKernel\EventListener\SessionListener::onKernelResponse() listener is registered twice in test environment.

Our tests for controllers where we set NO_AUTO_CACHE_CONTROL_HEADER flag started failing, because the flag is reset on the first call of onKernelResponse and the subsequent call overwrites the previously set headers.

How to reproduce

It works fine on 5.3:

$ symfony new symfonysessionlistenertest53 --version="5.3.x@dev" --full
$ cd symfonysessionlistenertest53 
$ symfony console debug:event --env=test

"kernel.response" event
-----------------------
....
  #11     Symfony\Component\HttpKernel\EventListener\SessionListener::onKernelResponse()            -1000
...

But is registered twice on 5.4:

$ symfony new symfonysessionlistenertest54 --version="5.4.x@dev" --full
$ cd symfonysessionlistenertest54 
$ symfony console debug:event --env=test

"kernel.response" event
-----------------------
...
  #10     Symfony\Component\HttpKernel\EventListener\SessionListener::onKernelResponse()            -1000
  #11     Symfony\Component\HttpKernel\EventListener\SessionListener::onKernelResponse()            -1000
...

Possible Solution

No response

Additional Context

Note: The listener is set only once in dev and prod envs.

I guess that the issue may be related to #41390.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0