Upgrade to 5.4 failed: Invalid service the class is not set. #44342

gjuric · 2021-11-29T18:45:23Z

Symfony version(s) affected

5.4.0

Description

I've just tried updating from latest 5.3.11 to 5.4.0 and after the packages have been updated the container can not be built with complaints about my custom repositories not having a class set.

How to reproduce

I've created a reproducer here: https://github.com/gjuric/symfony_5_4_bug/

The repositories are defined like this:

    <service id="Namespace\MyCustomDoctrineRepository">
        <factory service="doctrine.orm.default_entity_manager" method="getRepository"/>
        <argument>FQCN_of_my_entity</argument>
    </service>

I've tried adding the class attribute to the <service> tag but it doesn't help.

Possible Solution

No response

Additional Context

When compiler is trying to build this server it sees it has a factory and tries to fetch the Class here:

symfony/src/Symfony/Component/DependencyInjection/Compiler/AbstractRecursivePass.php

Line 132 in a12336a

$class = $this->container->findDefinition((string) $class)->getClass();

$this->container->findDefinition((string) $class) returns and instance of Symfony\Component\DependencyInjection\ChildDefinition where parent is set to doctrine.orm.entity_manager.abstract and the class property is set to null. This null is then passed to return $this->getReflectionMethod(new Definition($class), $method); where it is of course not possible to build a definition since $class is null.

The text was updated successfully, but these errors were encountered:

wouterj · 2021-11-29T18:50:27Z

Hi @gjuric!

Can you provide a minimal reproducer that shows this error? That'll help someone (or you 😉) to debug this error.

gjuric · 2021-11-29T20:55:38Z

Sure, I will take a look at it tomorrow, I've tried setting up the skeleton app from the linked documentation but it installs v6, after manually downgrading to 5.4 I wasn't able to install the maker bundle because of dependencies and downgrading to 5.3 to get the maker bundle broke the skeleton app because of a missing method in the MicroKernelTrait so I need to take care of that first :)

signor-pedro · 2021-11-30T08:35:01Z

Hi, at our company we're experiencing the same :) thanks @gjuric for the minimal reproducer :)

gjuric · 2021-11-30T10:03:45Z

I am having trouble generating a minimal reproducer since there using a factory to get the Entity Repository works :(

If I downgrade the symfony/framework-bundle package to v5.3.11 and leave all other packages upgraded everything works. The debug output when running bin/console is:


  [Symfony\Component\DependencyInjection\Exception\RuntimeException]
  Invalid service "Namespace\DoctrineOrmMyEntityRepository": the class is not set.


Exception trace:
  at vendor/symfony/dependency-injection/Compiler/AbstractRecursivePass.php:178
 Symfony\Component\DependencyInjection\Compiler\AbstractRecursivePass->getReflectionMethod() at vendor/symfony/dependency-injection/Compiler/AbstractRecursivePass.php:143
 Symfony\Component\DependencyInjection\Compiler\AbstractRecursivePass->getConstructor() at vendor/symfony/dependency-injection/Compiler/AttributeAutoconfigurationPass.php:102
 Symfony\Component\DependencyInjection\Compiler\AttributeAutoconfigurationPass->processValue() at vendor/symfony/dependency-injection/Compiler/AbstractRecursivePass.php:81
 Symfony\Component\DependencyInjection\Compiler\AbstractRecursivePass->processValue() at vendor/symfony/dependency-injection/Compiler/AttributeAutoconfigurationPass.php:88
 Symfony\Component\DependencyInjection\Compiler\AttributeAutoconfigurationPass->processValue() at vendor/symfony/dependency-injection/Compiler/AbstractRecursivePass.php:46
 Symfony\Component\DependencyInjection\Compiler\AbstractRecursivePass->process() at vendor/symfony/dependency-injection/Compiler/AttributeAutoconfigurationPass.php:77
 Symfony\Component\DependencyInjection\Compiler\AttributeAutoconfigurationPass->process() at vendor/symfony/dependency-injection/Compiler/Compiler.php:82
 Symfony\Component\DependencyInjection\Compiler\Compiler->compile() at vendor/symfony/dependency-injection/ContainerBuilder.php:757
 Symfony\Component\DependencyInjection\ContainerBuilder->compile() at vendor/symfony/http-kernel/Kernel.php:548
 Symfony\Component\HttpKernel\Kernel->initializeContainer() at vendor/symfony/http-kernel/Kernel.php:789
 Symfony\Component\HttpKernel\Kernel->preBoot() at vendor/symfony/http-kernel/Kernel.php:128
 Symfony\Component\HttpKernel\Kernel->boot() at vendor/symfony/framework-bundle/Console/Application.php:168
 Symfony\Bundle\FrameworkBundle\Console\Application->registerCommands() at vendor/symfony/framework-bundle/Console/Application.php:74
 Symfony\Bundle\FrameworkBundle\Console\Application->doRun() at vendor/symfony/console/Application.php:171
 Symfony\Component\Console\Application->run() at vendor/symfony/runtime/Runner/Symfony/ConsoleApplicationRunner.php:54
 Symfony\Component\Runtime\Runner\Symfony\ConsoleApplicationRunner->run() at vendor/autoload_runtime.php:35
 require_once() at bin/console:10

Couple of things to add:

we are using multiple entity managers
bundles that define these repositories add a DoctrineOrmMappingsPass::createXmlMappingDriver() compiler Pass to the container so entites from the bundle are registered with Doctrine

gjuric · 2021-11-30T12:34:22Z

I've managed to create a reproducer and I've updated the issue with additional context.

wouterj · 2021-11-30T17:16:59Z

Thanks a lot @gjuric!

The lines you mention in the PR description haven't been changed for years. However, if I use Symfony 5.3 I get $class = 'Doctrine\ORM\EntityManager';, whereas it's null in Symfony 5.4.

Would be cool if someone can dig deeper into this :)

fancyweb · 2021-11-30T17:46:59Z

Looks like a bug on 4.4 here

symfony/src/Symfony/Component/DependencyInjection/Compiler/AbstractRecursivePass.php

Line 137 in 382cde2

$class = $class->getClass();

. $class can be null, even with $required = false, getConstructor() ends up throwing.

getConstructor() is called here

symfony/src/Symfony/Component/DependencyInjection/Compiler/AttributeAutoconfigurationPass.php

Line 102 in a12336a

    
           if ($this->parameterAttributeConfigurators && $constructorReflector = $this->getConstructor($value, false)) {

.

I guess if there is no class in the definition with $required = false, getConstructor() should return null.

fancyweb · 2021-12-01T08:55:19Z

Actually, let's catch the exception, that's what we do everywhere else, I'll submit a patch.

…rs in AttributeAutoconfigurationPass if we can't get the constructor reflector (fancyweb) This PR was merged into the 5.4 branch. Discussion ---------- [DependencyInjection] Skip parameter attribute configurators in AttributeAutoconfigurationPass if we can't get the constructor reflector | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | #44342 | License | MIT | Doc PR | - `$required = false` on `getConstructor()` doesn't mean it doesn't throw. I have looked at our other usages, and we catch the exception when we want to ignore it. I'd still like to return null when the definition class is null though (on 4.4). Commits ------- b2fe0e0 [DependencyInjection] Skip parameter attribute configurators in AttributeA 8000 utoconfigurationPass if we can't get the constructor reflector

gjuric · 2021-12-06T10:35:13Z

@nicolas-grekas @fancyweb any chance of 5.4.1 being released with this fix in it?

xabbuh · 2021-12-06T10:55:08Z

Patch releases are usually done regularly once a month.

…ecursivePass (fancyweb) This PR was merged into the 4.4 branch. Discussion ---------- [DependencyInjection] Resolve ChildDefinition in AbstractRecursivePass | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | #44342 | License | MIT | Doc PR | - At least `AttributeAutoconfigurationPass` (5.4 new pass) relies on `AbstractRecursivePass` and is executed before `ResolveChildDefinitionsPass` so child definitions are not necessary resolved in `AbstractRecursivePass`. Doing it on 4.4 to have the same behavior on all maintained branches. It fixes #44342 in a better way because the final class of the factory can be resolved. Commits ------- acbee81 [DependencyInjection] Resolve ChildDefinition in AbstractRecursivePass

gjuric added the Bug label Nov 29, 2021

carsonbot added the Status: Needs Review label Nov 29, 2021

wouterj added Status: Waiting feedback Status: Needs Review and removed Status: Needs Review labels Nov 29, 2021

wouterj added Status: Reviewed and removed Status: Needs Review Status: Waiting feedback labels Nov 30, 2021

fancyweb self-assigned this Nov 30, 2021

fancyweb mentioned this issue Dec 1, 2021

[DependencyInjection] Skip parameter attribute configurators in AttributeAutoconfigurationPass if we can't get the constructor reflector #44385

Merged

nicolas-grekas closed this as completed Dec 1, 2021

fancyweb mentioned this issue Dec 2, 2021

[DependencyInjection] Resolve ChildDefinition in AbstractRecursivePass #44418

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Upgrade to 5.4 failed: Invalid service the class is not set. #44342

Upgrade to 5.4 failed: Invalid service the class is not set. #44342

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Upgrade to 5.4 failed: Invalid service the class is not set. #44342

Upgrade to 5.4 failed: Invalid service the class is not set. #44342

Comments

Uh oh!

Symfony version(s) affected

Description

How to reproduce

Possible Solution

Additional Context

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!