[Console] Hidden option using PHP 8 AsCommand attribute #41942

duboiss · 2021-07-02T14:07:40Z

Symfony version(s) affected: 5.3.0 to current latest 5.3.3

Description
I always get a different behavior between hidden option in php 8 attribute (#[AsCommand]) and the setHidden() method in configure method even with the fix #41686. Also with cache:clear.

How to reproduce
I've created a project (see below) to simplify the tests, but :

Declare the DefaultCommand class in src/Command:

<?php

namespace App\Command;

use Symfony\Component\Console\Application;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\ArrayInput;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;

class DefaultCommand extends Command
{
    protected static $defaultName = 'app:default';

    protected function configure(): void
    {
        $this
            ->setDescription('wrapper')
            ->setHidden(true)
        ;
    }

    protected function execute(InputInterface $input, OutputInterface $output): ?int
    {
        /** @var Application $application */
        $application = $this->getApplication();

        $command = $application->find('list');
        $arguments = ['namespace' => 'app'];

        $listInput = new ArrayInput($arguments);

        return $command->run($listInput, $output);
    }
}

Declare a new Application.php class in src folder and use it in bin/console instead of the default Application class (just need to change the namespace):

src/Application.php

<?php

declare(strict_types=1);

namespace App;

use App\Command\DefaultCommand;
use Symfony\Bundle\FrameworkBundle\Console\Application as SymfonyApplication;
use Symfony\Component\HttpKernel\KernelInterface;

class Application extends SymfonyApplication
{
    public function __construct(KernelInterface $kernel)
    {
        parent::__construct($kernel);

        if ($defaultName = DefaultCommand::getDefaultName()) {
            $this->setDefaultCommand($defaultName);
        }
    }
}

bin/console

#!/usr/bin/env php
<?php

use App\Kernel;
use App\Application;

if (!is_file(dirname(__DIR__).'/vendor/autoload_runtime.php')) {
    throw new LogicException('Symfony Runtime is missing. Try running "composer require symfony/runtime".');
}

require_once dirname(__DIR__).'/vendor/autoload_runtime.php';

return function (array $context) {
    $kernel = new Kernel($context['APP_ENV'], (bool) $context['APP_DEBUG']);

    return new Application($kernel);
};

Make a random command, for exemple app:hello with or without PHP 8 attributes.
See the output of bin/console. Update DefaultCommand with PHP 8 #[AsCommand] attribute and observe the difference.

OR use the following project as exemple
https://github.com/duboiss/sfcommand

git clone https://github.com/duboiss/sfcommand
cd sfcommand
composer install
bin/console

git switch php8
bin/console

Additional context
Without attribute

With attribute

This is probably due to the fact that it has become lazy. Is there any way to keep the PHP 8 attribute and disable lazy (if that is the cause)?

The text was updated successfully, but these errors were encountered:

… PHP8 (a1812) This PR was merged into the 5.3 branch. Discussion ---------- [Console] Fix save correct name in setDefaultCommand() for PHP8 | Q | A | ------------- | --- | Branch? | 5.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #41942 | License | MIT | Doc PR | Fix save correct name in setDefaultCommand() for PHP8 Commits ------- 8a41694 fix setDefaultCommand

duboiss added the Bug label Jul 2, 2021

carsonbot added Console Status: Needs Review labels Jul 2, 2021

a1812 mentioned this issue Jul 6, 2021

[Console] Fix save correct name in setDefaultCommand() for PHP8 #42009

Merged

fabpot closed this as completed Jul 8, 2021

weitzman mentioned this issue Sep 6, 2021

Support hidden options consolidation/annotated-command#233

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

[Console] Hidden option using PHP 8 AsCommand attribute #41942

[Console] Hidden option using PHP 8 AsCommand attribute #41942

Uh oh!

[Console] Hidden option using PHP 8 AsCommand attribute #41942

[Console] Hidden option using PHP 8 AsCommand attribute #41942

Comments

Uh oh!