8000 [Translation] Overridden translations are not used · Issue #40226 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content
8000

[Translation] Overridden translations are not used #40226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mikaelcom opened this issue Feb 17, 2021 · 3 comments
Closed

[Translation] Overridden translations are not used #40226

mikaelcom opened this issue Feb 17, 2021 · 3 comments
Labels
Bug Status: Needs Review Translation

Comments

@mikaelcom
Copy link

Symfony version(s) affected: 4.4.19

Description
As indicated in this comment , I can't override a Bundle translations using a file at translations/{filename}.

How to reproduce

  • Use Symfony components 4.4.19
  • Require SonataAdminBundle
  • Create the translation file translations/SonataAdminBundle.fr.xlf
  • Add this translation for example:
            <trans-unit id="action_delete">
                <source>action_delete</source>
                <target></target>
            </trans-unit>
  • Display a entity list with the action delete
  • Delete button text is still Supprimer in French and not an empty text

Possible Solution
Possible origin of the issue is detailed in this comment

@mikaelcom mikaelcom added the Bug label Feb 17, 2021
@stof
Copy link
Member
stof commented Feb 17, 2021 •
edited
Loading

the commit on which you commented is not part of 4.4.19. It is precisely the commit fixing the bug, which will be part of the 4.4.20 (and 5.2.3) release at the end of the month.

@stof stof closed this as completed Feb 17, 2021
@stof
Copy link
Member
stof commented Feb 17, 2021

For reference, the bug affecting the 4.4.19 release was reported at #40014

@mikaelcom
Copy link
Author

the commit on which you commented is not part of 4.4.19. It is precisely the commit fixing the bug, which will be part of the 4.4.20 release at the end of the month.

Ok, I had upgraded to 5.2.3 when I first encountered the issue. Thanks for the quick reply!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Status: Needs Review Translation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stof @mikaelcom @carsonbot
0