8000 [Cache] No logs with TagAwareAdapter · Issue #40108 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Cache] No logs with TagAwareAdapter #40108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fancyweb opened this issue Feb 5, 2021 · 3 comments
Closed

[Cache] No logs with TagAwareAdapter #40108

fancyweb opened this issue Feb 5, 2021 · 3 comments
Labels
Bug Cache Status: Needs Review

Comments

@fancyweb
Copy link
Contributor
fancyweb commented Feb 5, 2021

Symfony version(s) affected: all

Contrary to other adapters, TagAwareAdapter does not have a $logger property so it produces no logs. It's especially visible if you have an existing pool: adding tags: true makes the logs disappear. Implementing LoggerAwareInterface and using LoggerAwareTrait + tweaking some DI definitions resolve it. Can we consider this a bug fix, or is that a feature?
@fancyweb fancyweb added the Bug label Feb 5, 2021
@nicolas-grekas
Copy link
Member

But a TagAwareAdapter takes another pool as argument. It's expected that this decorated pool logs. Maybe that's a wiring issue then?

@fancyweb
Copy li 8000 nk
Contributor Author
fancyweb commented Feb 5, 2021

The decorated pool does not log.
https://github.com/symfony/symfony/blob/4.4/src/Symfony/Component/Cache/Traits/ContractsTrait.php#L88 $this->logger here does not exist.

@nicolas-grekas
Copy link
Member
nicolas-grekas commented Feb 5, 2021 •
edited
Loading

That's why then. PR welcome :)

@fancyweb fancyweb mentioned this issue Apr 8, 2021
Merged
nicolas-grekas added a commit that referenced this issue Apr 11, 2021
@nicolas-grekas
bug #40740 [Cache][FrameworkBundle] Fix logging for TagAwareAdapter (…
4e904ec 
…fancyweb)

This PR was merged into the 4.4 branch.

Discussion
----------

[Cache][FrameworkBundle] Fix logging for TagAwareAdapter

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | #40108
| License       | MIT
| Doc PR        | -

Commits
-------

6b0beca [Cache] [FrameworkBundle] Fix logging for TagAwareAdapter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Cache Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nicolas-grekas @fancyweb @carsonbot
0