8000 ESI renderer assumes current application is the target of the include · Issue #39130 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

ESI renderer assumes current application is the target of the include #39130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Bilge opened this issue Nov 20, 2020 · 7 comments
Closed

ESI renderer assumes current application is the target of the include #39130

Bilge opened this issue Nov 20, 2020 · 7 comments
Labels
Feature HttpKernel Stalled Status: Needs Review

Comments

@Bilge
Copy link
Contributor
Bilge commented Nov 20, 2020

Symfony version(s) affected: 5.1.8
Description
ESI rendering sounds great in theory: I can work without an edge cache in development because Symfony will resolve the include by itself. However, calling out to an external resource does not work.

How to reproduce
{{ render_esi('https://example.com/foo') }} will error with:

An exception has been thrown during the rendering of a template ("No route found for "GET /foo"").

Despite the fact that example.com has nothing to do with our application, it ignores the hostname and just assumes the path can be found within our application.
@Bilge Bilge added the Bug label Nov 20, 2020
@stof
Copy link
Member
stof commented Nov 20, 2020 •
edited
Loading

The builtin ESI implementation in HttpCache does not support external includes, only internal ones.

For external ESI fragments, you will need to use Varnish (or another ESI proxy)

@Bilge
Copy link
Contributor Author
Bilge commented Nov 20, 2020

OK, then this is a feature request rather than a bug report, but this isn't mentioned anywhere in the docs.

@derrabus
Copy link
Member

I don't think that we want to reimplement Varnish. I'd vote for "won't fix".

@derrabus derrabus added Feature and removed Bug labels Nov 20, 2020
@stof
Copy link
Member
stof commented Nov 20, 2020

I suggest opening an issue in the docs repo to improve the doc on that topic.

And indeed, for HttpCache, I'd vote for "won't fix" as well.

@Bilge Bilge mentioned this issue Nov 30, 2020
Closed
@carsonbot
Copy link

Thank you for this suggestion.
There has not been a lot of activity here for a while. Would you still like to see this feature?

@carsonbot
Copy link

Could I get an answer? If I do not hear anything I will assume this issue is resolved or abandoned. Please get back to me <3

@carsonbot
Copy link

Hey,

I didn't hear anything so I'm going to close it. Feel free to comment if this is still relevant, I can always reopen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature HttpKernel Stalled Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@stof @Bilge @derrabus @carsonbot
0