8000 PHP7.2 on Windows + php.ini directive can cause flaky tests · Issue #38320 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content
PHP7.2 on Windows + php.ini directive can cause flaky tests #38320
Closed
@vasilvestre

Description

@vasilvestre

Symfony version(s) affected: 5.2 (because I found it in RateLimiter component)

Description

Windows 10 with PHP 7.2 and ini directive 'serialize_precision' set to 14 cause bug in time sensitive test on AppVeyor (actually, but only on local) because of this : https://github.com/symfony/symfony/blob/master/.appveyor.yml#L28

    - echo serialize_precision=14 >> php.ini-min

How to reproduce

The bug can be seen here : https://ci.appveyor.com/project/fabpot/symfony/builds/35429264 but it happens more often. I will make a reproducer if possible

Possible Solution

serialize_precision set to 16 will work for a long time (at it actually fail to deal with unix timestamp to float) but -1 is used to allow system best value optimisation

.appveyor.yml
-    - echo serialize_precision=14 >> php.ini-min
+   - echo serialize_precision=-1 >> php.ini-min

Maybe the issue isn't related to Symfony itself but at least we can fix it.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0