8000 [Yaml] valid comment crashes · Issue #38223 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Yaml] valid comment crashes #38223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ro0NL opened this issue Sep 17, 2020 · 5 comments
Closed

[Yaml] valid comment crashes #38223

ro0NL opened this issue Sep 17, 2020 · 5 comments
Labels
Bug Status: Needs Review Yaml

Comments

@ro0NL
Copy link
Contributor
ro0NL commented Sep 17, 2020 •
edited
Loading

Symfony version(s) affected: 5.1

Given e.g.

foo:
    bar:
        baz:
            access_key: 'literal'#'%env(ACCESS_KEY)%'

it crashes with Unexpected characters near "#'%env(ACCESS_KEY)%'" (note the quotes around literal)

but is succesfully parses at http://www.yamllint.com/

adding a space before # solves it in Symfony, but i was too lazy :)
@ro0NL ro0NL added the Bug label Sep 17, 2020
@xabbuh xabbuh added the Yaml label Sep 17, 2020
@xabbuh
Copy link
Member
xabbuh commented Sep 17, 2020

here is how it should be parsed: https://yaml-online-parser.appspot.com/?yaml=foo%3A%0A++++bar%3A%0A++++++++baz%3A%0A++++++++++++access_key%3A+%27literal%27%23%27%25env(ACCESS_KEY)%25%27&type=json

@xabbuh
Copy link
Member
xabbuh commented Sep 17, 2020

I am going to look into it.

@xabbuh xabbuh mentioned this issue Sep 18, 2020
Merged
@xabbuh
Copy link
Member
xabbuh commented Sep 18, 2020

@ro0NL Can you confirm that #38229 fixes this?

@fabpot fabpot closed this as completed Sep 18, 2020
xabbuh added a commit that referenced this issue Sep 18, 2020
@xabbuh
bug #38229 [Yaml] fix parsing comments not prefixed by a space (xabbuh)
74f41f3 
This PR was merged into the 3.4 branch.

Discussion
----------

[Yaml] fix parsing comments not prefixed by a space

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #38223
| License       | MIT
| Doc PR        |

Commits
-------

35b223a fix parsing comments not prefixed by a space
@ro0NL
Copy link
Contributor Author
ro0NL commented Sep 18, 2020

@xabbuh yes, all good 👍

@xabbuh
Copy link
Member
xabbuh commented Sep 18, 2020

@ro0NL Thanks for the confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Status: Needs Review Yaml
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@fabpot @ro0NL @xabbuh @carsonbot
0