You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Symfony version(s) affected: 4.4.13 (introduced with 4.4.8)
Description
We have defined in the framework.yaml an own cache pool. We are also decorating that cache.pool. After this the \Symfony\Component\Cache\DependencyInjection\CacheCollectorPass is throwing an ServiceNotFoundException. It seems so that the definition name changes while decorating.
How to reproduce
Create a new cache pool in framework.yaml
Decorate it
Container cannot be created anymore due missing definition
Possible Solution
Check in addToCollector is it an alias or an actual definition
Additional context
The text was updated successfully, but these errors were encountered:
…(shyim)
This PR was merged into the 4.4 branch.
Discussion
----------
[Cache] Fix CacheCollectorPass with decorated cache pools
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | Fix#38055
| License | MIT
| Doc PR |
The `getDefinition` call in `addToCollector` does not work when the service is decorated. Also instances will be added with the decoration name. This looks weird in the profiler. I have changed it to prefer the attribute name.
Before:

After: (`\Shopware\Storefront\Framework\Cache\CacheDecorator` did go into `cache.object`)

Commits
-------
9734427 Fix CacheCollectorPass with decorated cache pools
Uh oh!
There was an error while loading. Please reload this page.
Symfony version(s) affected: 4.4.13 (introduced with 4.4.8)
Description
We have defined in the framework.yaml an own cache pool. We are also decorating that cache.pool. After this the
\Symfony\Component\Cache\DependencyInjection\CacheCollectorPass
is throwing anServiceNotFoundException
. It seems so that the definition name changes while decorating.How to reproduce
framework.yaml
Possible Solution
Check in
addToCollector
is it an alias or an actual definitionAdditional context
The text was updated successfully, but these errors were encountered: