8000 [Form] Underscores Stripped From Prototype Label · Issue #3738 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content
8000

[Form] Underscores Stripped From Prototype Label #3738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
umpirsky opened this issue Mar 30, 2012 · 1 comment
Closed

[Form] Underscores Stripped From Prototype Label #3738

umpirsky opened this issue Mar 30, 2012 · 1 comment
Labels
Bug Form

Comments

@umpirsky
Copy link
Contributor

When rendering collection of forms and using default prototype name (__name__), label is stripping underscores and renders as name instead __name__ which makes it non replaceable.
@umpirsky
Copy link
Contributor Author

I opened a PR with test for this issue.

@webmozart webmozart mentioned this issue Apr 6, 2012
Merged
fabpot added a commit that referenced this issue Apr 7, 2012
@fabpot
merged branch bschussek/issue3738 (PR #3807)
526fb7b 
Commits
-------

6584721 [Form] Improved labels generated by default from form names
6e0b03a [Form] Fixed label of prototype in CollectionType
fc342d1 Merge remote branch 'umpirsky/collection-name' into issue3738
f91660d Added test for prototype label.

Discussion
----------

[Form] Fixed default label generated for the CollectionType prototype

Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: #3738, #3739
Todo: -

![Travis Build Status](https://secure.travis-ci.org/bschussek/symfony.png?branch=issue3738)

(the fact that the build fails seems to origin from the broken master)
@Thorry84 Thorry84 mentioned this issue Apr 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Form
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@webmozart @umpirsky
0