8000 [Form] New items in collection form type are not hydrated to proper dataClass · Issue #3694 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Form] New items in collection form type are not hydrated to proper dataClass #3694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ghost opened this issue Mar 25, 2012 · 2 comments
Closed

[Form] New items in collection form type are not hydrated to proper dataClass #3694

ghost opened this issue Mar 25, 2012 · 2 comments
Labels
Form

Comments

@ghost
Copy link
ghost commented Mar 25, 2012

new items in collection are not hydrated to dataClass but they are as ARRAY's

it means that after form bind i'll get :

class Foo {
    private items ->> PersistedColleaction{
        col = ArrayCollection {
            [0] = FooClass() // already in collection
            [1] = array('foo':'faa', ... ) // new items added to form are not hydrated back to proper class but they are  arrays 
        }
    }
}

... it's new feature of master branch?
@vicb
Copy link
Contributor
vicb commented Mar 26, 2012

related to #3354

@Burgov Burgov mentioned this issue Mar 31, 2012
Closed
@webmozart webmozart mentioned this issue Apr 5, 2012
Merged
@webmozart
Copy link
Contributor

I'm closing this ticket as it is a duplicate of #3354.

fabpot added a commit that referenced this issue Apr 11, 2012
@fabpot
merged branch bschussek/issue3354 (PR #3789)
05842c5 
Commits
-------

8329087 [Form] Moved calculation of ChoiceType options to closures
5adec19 [Form] Fixed typos
cb87ccb [Form] Failing test for empty_data option BC break
b733045 [Form] Fixed option support in Form component

Discussion
----------

[Form] Fixed option support in Form component

Bug fix: yes
Feature addition: no
Backwards compatibility break: yes
Symfony2 tests pass: yes
Fixes the following tickets: #3354, #3512, #3685, #3694
Todo: -

![Travis Build Status](https://secure.travis-ci.org/bschussek/symfony.png?branch=issue3354)

This PR also introduces a new helper `DefaultOptions` for solving option graphs. It accepts default options to be defined on various layers of your class hierarchy. These options can then be merged with the options passed by the user. This is called *resolving*.

The important feature of this utility is that it lets you define *lazy options*. Lazy options are specified using closures that are evaluated when resolving and thus have access to the resolved values of other (potentially lazy) options. The class detects cyclic option dependencies and fails with an exception in this case.

For more information, check the inline documentation of the `DefaultOptions` class and the UPGRADE file.

@fabpot: Might this be worth a separate component? (in total the utility consists of five classes with two associated tests)

---------------------------------------------------------------------------

by beberlei at 2012-04-05T08:54:10Z

"The important feature of this utility is that it lets you define lazy options. Lazy options are specified using closures"

What about options that are closures? are those differentiated?

---------------------------------------------------------------------------

by bschussek at 2012-04-05T08:57:35Z

@beberlei Yes. Closures for lazy options receive a Symfony\Component\Form\Options instance as first argument. All other closures are interpreted as normal values.

---------------------------------------------------------------------------

by stof at 2012-04-05T11:09:49Z

I'm wondering if these classes should go in the Config component. My issue with it is that it would add a required dependency to the Config component and that the Config component mixes many different things in it already (the loader part, the resource part, the definition part...)

---------------------------------------------------------------------------

by sstok at 2012-04-06T13:36:36Z

Sharing the Options class would be great, and its more then one class so why not give it its own Component folder?
Filesystem is just one class, and that has its own folder.

Great job on the class bschussek :clap:

---------------------------------------------------------------------------

by bschussek at 2012-04-10T12:32:34Z

@fabpot Any input?

---------------------------------------------------------------------------

by bschussek at 2012-04-10T13:54:13Z

@fabpot Apart from the decision about the final location of DefaultOptions et al., could you merge this soon? This would make my work a bit easier since this one is a blocker.

---------------------------------------------------------------------------

by fabpot at 2012-04-10T18:08:18Z

@bschussek: Can you rebase on master? I will merge afterwards. Thanks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Form
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@webmozart @vicb
0