8000 [Typo] Rename occurence to occurrence · Issue #36242 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Typo] Rename occurence to occurrence #36242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pgrimaud opened this issue Mar 27, 2020 · 4 comments · Fixed by #36244
Closed

[Typo] Rename occurence to occurrence #36242

pgrimaud opened this issue Mar 27, 2020 · 4 comments · Fixed by #36244
Labels
PhpUnitBridge

Comments

@pgrimaud
Copy link
Contributor

Description

You're using the term occurence in some files :

  • src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler/DeprecationNotice.php
  • src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler/DeprecationGroup.php

And associated tests :

  • src/Symfony/Bridge/PhpUnit/Tests/DeprecationErrorHandler/DeprecationNoticeTest.php
  • src/Symfony/Bridge/PhpUnit/Tests/DeprecationErrorHandler/DeprecationGroupTest.php

Occurence is the French term. You should use Occurrence instead.
@pgrimaud pgrimaud changed the title [Improvement] Rename occurence to occurrence [Typo] Rename occurence to occurrence Mar 27, 2020
@nicolas-grekas
Copy link
Member

Up for a PR? Branch 3.4 isn't it?

@pgrimaud
Copy link
Contributor Author

This typo was added with the PR #35271.
It's for 5.1, so I could make a PR on master?

@nicolas-grekas
Copy link
Member

Master then yes, thanks.

@wouterj
Copy link
Member
wouterj commented Mar 27, 2020

Yes, the PR should be on master indeed.

Please mention the PR introducing these methods in your description. As the methods where not yet in a Symfony release, they can be renamed without breaking backwards compatibility. If that's clear for the core team, you're more likely to get quick approval for your PR :)

@pgrimaud pgrimaud mentioned this issue Mar 27, 2020
Merged
@xabbuh xabbuh closed this as completed in eb0e47b Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
PhpUnitBridge
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Typo] Rename occurence to occurrence
4 participants
@nicolas-grekas @wouterj @pgrimaud @xabbuh
0