8000 [RFC] static analysis tools · Issue #36164 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[RFC] static analysis tools #36164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vv12131415 opened this issue Mar 22, 2020 · 4 comments
Closed

[RFC] static analysis tools #36164

vv12131415 opened this issue Mar 22, 2020 · 4 comments

Comments

@vv12131415
Copy link
Contributor

Add phpstan and psalm to the project.
This will add internal code and public api strictness.
Since they (SA tools) support baselines (the file with all of old errors) it will be easy to start with them and fix issues along the way of future development.
@fabpot
Copy link
Member
fabpot commented Mar 22, 2020

Look for similar issues, this has been discussed in the past.

@fabpot fabpot closed this as completed Mar 22, 2020
@JeroenVanOort
Copy link

@vladyslavstartsev Did you find the relevant issues? I couldn't really. I'm wanted to open a similar RFC for another framework and I'm looking for reasons people do and don't include SA in their projects.

@wouterj
Copy link
Member
wouterj commented Mar 28, 2020

See e.g. #25459

@JeroenVanOort
Copy link

Thanks so much for the reference!

If I understand correctly, this was all discussed when PHPStan didn't yet have the baseline feature. So, at that time all existing reported problems would need to be fixed before PHPStan could be used in CI. This is no longer necessary. It could be done more gradually and manageable now.

Also, the world hasn't stood still. Because supported for older PHP versions has been dropped, there's a lot less risk of changes breaking BC.

And regarding the argument 'the current code is fine': if that is the case, it wouldn't be a problem to assert that, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@fabpot @wouterj @JeroenVanOort @vv12131415
0