10000 [Form] Add a functional test suite · Issue #3612 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Form] Add a functional test suite #3612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vicb opened this issue Mar 16, 2012 · 8 comments
Closed

[Form] Add a functional test suite #3612

vicb opened this issue Mar 16, 2012 · 8 comments
Labels
Enhancement Form

Comments

@vicb
Copy link
Contributor
vicb commented Mar 16, 2012

That would help a lot stabilizing the Form component.
@brikou
Copy link
Contributor
brikou commented Mar 16, 2012

+1 (even +2 if collections are func tested (js needed) ;) )

@vicb
Copy link
Contributor Author
vicb commented Mar 16, 2012

I don't think any JS is needed (it could be simulated)

@webmozart
Copy link
Contributor

Just for reference, we do already have integration tests in all the *TypeTests and *LayoutTests.

@l3l0
Copy link
Contributor
l3l0 commented Apr 13, 2012

Hello,

I think can try do add some tests into form component.
@bschussek @vicb Can you tell how those functional tests should looks like?
Something like https://github.com/symfony/symfony/tree/master/src/Symfony/Bundle/FrameworkBundle/Tests/Functional or https://github.com/symfony/symfony/blob/master/src/Symfony/Bundle/SecurityBundle/Tests/Functional ?
or maybe it should be some kind of usage integration tests ?

@webmozart
Copy link
Contributor

@l3l0 I'm not sure yet which benefit we will have of further integration tests.

@vicb What problems are you trying to tackle with this request?

@vicb
Copy link
Contributor Author
vicb commented Apr 13, 2012

For example I was thinking of testing the collections (i.e. adding & removing childs). I thought it could help both stabilizing the component & documenting the usage. @bschussek feel free to close if you think it is not helpful.

@webmozart
Copy link
Contributor

@vicb This should be covered by CollectionTypeTest. I think that this ticket is actually already covered by the Type and Layout tests. If any test is missing there, we should add it, but we don't need a further layer of tests. Otherwise development will become too tedious (already now one has to adapt many tests).

@vicb
Copy link
Contributor Author
vicb commented Apr 18, 2012

#3983 could have been caught with functional tests ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement Form
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@webmozart @l3l0 @vicb @brikou
0