-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Form] Add a functional test suite #3612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
+1 (even +2 if collections are func tested (js needed) ;) ) |
I don't think any JS is needed (it could be simulated) |
Just for reference, we do already have integration tests in all the *TypeTests and *LayoutTests. |
Hello, I think can try do add some tests into form component. |
For example I was thinking of testing the collections (i.e. adding & removing childs). I thought it could help both stabilizing the component & documenting the usage. @bschussek feel free to close if you think it is not helpful. |
@vicb This should be covered by CollectionTypeTest. I think that this ticket is actually already covered by the Type and Layout tests. If any test is missing there, we should add it, but we don't need a further layer of tests. Otherwise development will become too tedious (already now one has to adapt many tests). |
#3983 could have been caught with functional tests ? |
That would help a lot stabilizing the Form component.
The text was updated successfully, but these errors were encountered: