10000 [HttpFoundation] Change visibility of emulateSameSite · Issue #35460 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[HttpFoundation] Change visibility of emulateSameSite #35460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Guite opened this issue Jan 24, 2020 · 2 comments
Closed

[HttpFoundation] Change visibility of emulateSameSite #35460

Guite opened this issue Jan 24, 2020 · 2 comments
Labels
HttpFoundation

Comments

@Guite
Copy link
Contributor
Guite commented Jan 24, 2020

For subclassing Symfony\Component\HttpFoundation\Session\Storage\NativeSessionStorage it would be very helpful if the emulateSameSite variable would become protected instead of private.

See https://github.com/symfony/symfony/blob/4.4/src/Symfony/Component/HttpFoundation/Session/Storage/NativeSessionStorage.php#L55

In my current use case I need to override the regenerate method (at least temporarily, for solving #28577) and to avoid breaking behaviour I need to duplicate the whole variable including everything which reads or writes into it.
@Guite Guite changed the title Change visibility of emulateSameSite [HttpFoundation] Change visibility of emulateSameSite Jan 24, 2020
@Guite Guite mentioned this issue Jan 24, 2020
Closed
@linaori
Copy link
Contributor
linaori commented Jan 24, 2020

If this is a temporary workaround, wouldn't it be easier to use reflection at some point to make it accessible?

@Guite
Copy link
Contributor Author
Guite commented Jan 24, 2020

No. Because there may be other use cases for subclasses with partial overriding.

@Guite Guite mentioned this issue Feb 9, 2020
Closed
@Guite Guite closed this as completed Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
HttpFoundation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Guite @linaori @xabbuh
0