10000 Error handling is different from previous versions in 4.4 and 5.0. · Issue #35445 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Error handling is different from previous versions in 4.4 and 5.0. #35445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
siganushka opened this issue Jan 23, 2020 · 1 comment
Closed

Error handling is different from previous versions in 4.4 and 5.0. #35445

siganushka opened this issue Jan 23, 2020 · 1 comment

Comments

@siganushka
Copy link
Contributor

Symfony version(s) affected: 4.4 & 5.0

Description
Error handling behaves differently from previous versions in 4.4 and 5.0.

How to reproduce

in my services.yaml (using default):

// ./config/services.yaml

# This file is the entry point to configure your own services.
# Files in the packages/ subdirectory configure your dependencies.

# Put parameters here that don't need to change on each machine where the app is deployed
# https://symfony.com/doc/current/best_practices/configuration.html#application-related-configuration
parameters:

services:
    # default configuration for services in *this* file
    _defaults:
        autowire: true      # Automatically injects dependencies in your services.
        autoconfigure: true # Automatically registers your services as commands, event subscribers, etc.

    # makes classes in src/ available to be used as services
    # this creates a service per class whose id is the fully-qualified class name
    App\:
        resource: '../src/*'
        exclude: '../src/{DependencyInjection,Entity,Migrations,Tests,Kernel.php}'

    # controllers are imported separately to make sure services can be injected
    # as action arguments even if you don't extend any base controller class
    App\Controller\:
        resource: '../src/Controller'
        tags: ['controller.service_arguments']

    # add more service definitions when explicit configuration is needed
    # please note that last definitions always *replace* previous ones

in my controller:

// ./src/Controller/DefaultController.php

class DefaultController extends AbstractController
{
    /**
     * @Route("/default", name="default")
     */
    public function index()
    {
        $var = 'syntax error with no semicolon' // syntax error
    }
}

When a syntax error occurs, error messages are displayed in versions 4.3 and earlier, including the number of lines where the error occurred:

image

But in 4.4 and 5.0, when a syntax error occurs, it shows that the class cannot be found:

image

I'm not sure if the problem is from dependency-injection or error-handler.
@xabbuh
Copy link
Member
xabbuh commented Jan 23, 2020

Related to #34658 and/or #35256?

This was referenced Jan 27, 2020
Closed
Merged
nicolas-grekas added a commit that referenced this issue Feb 3, 2020
@nicolas-grekas
bug #35557 [Config] dont catch instances of Error (nicolas-grekas)
78641e0 
This PR was merged into the 3.4 branch.

Discussion
----------

[Config] dont catch instances of Error

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #35445, fix #35256
| License       | MIT
| Doc PR        | -

Commits
-------

e94c3fb [Config] dont catch instances of Error
@nicolas-grekas nicolas-grekas mentioned this issue Feb 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nicolas-grekas @xabbuh @siganushka
0