Check for performance improvements in Symfony 5.0 #34708
Comments
|
The symfony 5.0 benchmark has |
|
btw, the 4.4 branch of the benchmark has the same issue |
|
Thanks Christophe! I've sent a PR to fix it for 5.0 (phpbenchmarks/symfony#13). Let's see what do they think about that. |
|
Hi, i'm phpbenchmarks owner. Benchmarks were done in PROD env, be sure of that: https://github.com/phpbenchmarks/symfony/blob/5.0_hello-world/.phpbenchmarks/initBenchmark.sh#L22 If they were done in DEV env, believe me, results will be really slower ;) |
|
@steevanb |
it still means that the default is going to be prod, so that's OK, it works for the purpose |
|
@stof Are you sure about it? On all my Symfony projects, I don't have |
|
hmm, indeed, I forgot that |
|
To be sure there is no problem with this benchmarks, i've relaunched Symfony 5.0 Hello World benchmark with 3 test cases:
Line APP_ENV=prod, APP_DEBUG not defined
APP_ENV=prod, APP_DEBUG=false
APP_ENV=dev, APP_DEBUG=true
As you can see, results are very similars when But with Too me, results available on phpbenchmarks.com are the right ones: |
|
@steevanb thanks for double checking the benchmarks (and thanks for creating and maintain that site!). We'll look for other posible solutions to improve performance. |
|
Thank you! If you need help to improve performances, you can contact me ;) |
that's expected, as the default value for |
|
Yes, this test was just here to prove it ;) |
|
Symfony 4.0 provided a significant redesign of the DI: case insensitive service ids, private services by defaut, etc. |
|
@nicolas-grekas , I think, the question is why it is slower, not why it's not faster. |
|
Cf #35252 |
|
I'm closing this because we didn't find any obvious error neither in Symfony 5.0 nor in the benchmarks. So, let's keep improving performance in separate issues and PRs. Thanks. |
Description
The
*.4Symfony versions are always the slowest in a branch (e.g.4.4is the slowest4.*version) because of all the deprecated features.For the same reason, the
*.0versions are usually the fastest Symfony versions. However, for5.0this didn't happen. See phpbenchmarks.com results:Maybe we could do some Blackfire profiling to find possible ways of improving Symfony 5.0 performance. Thanks!
The text was updated successfully, but these errors were encountered: