8000 [HttpKernel] Multiple container dumps when executing functional tests after clearing cache · Issue #34595 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[HttpKernel] Multiple container dumps when executing functional tests after clearing cache #34595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
juanmcasanova opened this issue Nov 25, 2019 · 2 comments
Closed

[HttpKernel] Multiple container dumps when executing functional tests after clearing cache #34595

juanmcasanova opened this issue Nov 25, 2019 · 2 comments

Comments

@juanmcasanova
Copy link

Symfony version(s) affected:
4.4.0
5.0.0

Description
When executing functional tests in Symfony 4.4 and 5.0, a new container initialization and dump is done for each test. This makes the overall test suite take a lot more time to complete (we have approximately 300 test running in our CI and it breaks the 1 hour limit when before it was taking no more than 14 minutes), in previous versions it was working fine. After the first time executing the tests (and if no change has been made that could cause a new container dump), it continues to work correctly.

This seems to be caused by the changes introduced in this commit: 7f9556c

For what I can see, as now the cache is checked only once per process, it keeps being not fresh even though a new container has already been initialized.

How to reproduce
This problem can be reproduced using the demo Symfony application (upgrading it to v4.4.0).

Possible Solution
The easier solution would be to mark the cache as fresh just after dumping the container here:

symfony/src/Symfony/Component/HttpKernel/Kernel.php

Lines 553 to 555 in 7719fc7

$this->dumpContainer($cache, $container, $class, $this->getContainerBaseClass());
unset($cache);

@Devristo
Copy link
Contributor

See #34567

@juanmcasanova
Copy link
Author

Missed that, sorry!

Closing this then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Devristo @juanmcasanova
0