10000 [Validator] issue with Range constraint while testing 4.4.x-dev · Issue #33700 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content
[Validator] issue with Range constraint while testing 4.4.x-dev #33700
Closed
@dmaicher

Description

@dmaicher

Symfony version(s) affected: 4.4.x-dev

Description
While testing Symfony 4.4.x-dev on my biggest work project I discovered a test fail:

Failed asserting that 'This value should be between 1 and 6.' contains "Bitte wählen Sie eine gültige Bewertung aus". 

This happens because of changes in this PR: #32435

Constraint:

    /**
     * @Assert\Range(min=1, max=6,
     *     minMessage="select_a_valid_rating_value",
     *     maxMessage="select_a_valid_rating_value",
     *     invalidMessage="select_a_valid_rating_value"
     * )
     */
    private $averageRating;

The form type that maps to this property specifies a custom translation domain via the translation_domain option. Inside this domain there are the translations for the message select_a_valid_rating_value.

Possible Solution
Is this a BC break? Or should it be documented?

Ping @Lctrs

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0