8000 Do not wire Traceable Event Dispatcher in CLI · Issue #32422 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Do not wire Traceable Event Dispatcher in CLI #32422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lyrixx opened this issue Jul 8, 2019 · 7 comments
Closed

Do not wire Traceable Event Dispatcher in CLI #32422

lyrixx opened this issue Jul 8, 2019 · 7 comments
Labels
DX DX = Developer eXperience (anything that improves the experience of using Symfony) EventDispatcher Performance Stalled

Comments

@lyrixx
Copy link
Member
lyrixx commented Jul 8, 2019

The TraceableEventDispatcher stores some informations for the
profiler. But in CLI it does not make sens, since the tooling does not
exist. I have already fixed such issue for monolog in #30339. I think we
should do the same for the TraceableEventDispatcher.

(I opened this discussion to keep a trace of a discussion in #32421)
@xabbuh xabbuh added DX DX = Developer eXperience (anything that improves the experience of using Symfony) EventDispatcher Performance labels Jul 8, 2019
@dmaicher
Copy link
Contributor
dmaicher commented Jul 8, 2019 •
edited
Loading

I actually got used to the fact that in dev environment lots of memory is used 🙈
So I usually execute longer running commands with --no-debug locally to avoid this.

When removing the TraceableEventDispatcher for CLI: Could there be an impact on this?
https://symfony.com/doc/current/testing/profiling.html

There is a data collector for events: https://github.com/symfony/symfony/blob/4.4/src/Symfony/Component/HttpKernel/DataCollector/EventDataCollector.php

@nicolas-grekas
Copy link
Member

How would we do this? This is compiled in the container, right?
PR welcome I suppose :)

@lyrixx
Copy link
Member Author
lyrixx commented Jul 30, 2019

@nicolas-grekas Yes, I know it's compiled and it's gonna be hard :/ I did it for monolog and that was quite easy. But the wiring of the Dispatcher is more complex...

@carsonbot
Copy link

Thank you for this issue.
There has not been a lot of activity here for a while. Has this been resolved?

@lyrixx
Copy link
Member Author
lyrixx commented Dec 18, 2020

Nope

@carsonbot carsonbot removed the Stalled label Dec 18, 2020
@kaznovac kaznovac mentioned this issue Feb 24, 2021
Closed
@carsonbot
Copy link

Thank you for this issue.
There has not been a lot of activity here for a while. Has this been resolved?

@lyrixx
Copy link
Member Author
lyrixx commented Jun 22, 2021

I don't have time to work on it, and it seems we can live with it. So let's close it for now

@lyrixx lyrixx closed this as completed Jun 22, 2021
@lyrixx lyrixx mentioned this issue Sep 3, 2021
Merged
@ 5B4D lyrixx lyrixx mentioned this issue May 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
DX DX = Developer eXperience (anything that improves the experience of using Symfony) EventDispatcher Performance Stalled
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@nicolas-grekas @lyrixx @dmaicher @xabbuh @carsonbot
0