8000 [HttpFoundation] Fix trailing space for mime-type with parameters by SaschaDens · Pull Request #29271 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[HttpFoundation] Fix trailing space for mime-type with parameters #29271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 22, 2018
Merged

[HttpFoundation] Fix trailing space for mime-type with parameters #29271

merged 1 commit into from
Nov 22, 2018

Conversation

SaschaDens
Copy link
Q A
Branch? 2.8
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #...
License MIT
Doc PR symfony/symfony-docs#...

This PR fixes a minor issue that we've discovered by exposing our API towards mobile applications which where sending the header as following content-type: application/json ;charset=UTF-8. Request is unable to determine the getContentType -> getFormat as json due to the whitespace at the end.

$request = Request::createFromGlobals();
$request->headers->set('CONTENT_TYPE', 'application/json ;charset=UTF-8'); // Forcing header for test
if ($request->getContentType() !== 'json') {
    // Return 415 (Unsupported Media Type) status code..
}

When checking https://tools.ietf.org/html/rfc7231#section-3.1.1.1 it seems that a space is part of the RFC spec. (Where OWS is abbreviated for Optional WhiteSpace)

media-type = type "/" subtype *( OWS ";" OWS parameter )

Current the following cases are supported:

  • application/json; charset=UTF-8
  • application/json;charset=UTF-8

The following are failing:

  • application/json ; charset=UTF-8
  • application/json ;charset=UTF-8

javiereguiluz
javiereguiluz approved these changes Nov 21, 2018
View reviewed changes
Copy link
Member
@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A very nice bug fix and your pull request explained everything perfectly! Thanks.

@fabpot
Copy link
Member
fabpot commented Nov 22, 2018

Thank you @SaschaDens.

@fabpot fabpot merged commit f4866bc into symfony:2.8 Nov 22, 2018
fabpot added a commit that referenced this pull request Nov 22, 2018
@fabpot
bug #29271 [HttpFoundation] Fix trailing space for mime-type with par…
e4a7fd8 
…ameters (Sascha Dens)

This PR was merged into the 2.8 branch.

Discussion
----------

[HttpFoundation] Fix trailing space for mime-type with parameters

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | yes
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

<!--
Write a short README entry for your feature/bugfix here (replace this comment block.)
This will help people understand your PR and can be used as a start of the Doc PR.
Additionally:
 - Bug fixes must be submitted against the lowest branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the master branch.
-->
This PR fixes a minor issue that we've discovered by exposing our API towards mobile applications which where sending the header as following `content-type: application/json ;charset=UTF-8`. Request is unable to determine the `getContentType -> getFormat` as **json** due to the whitespace at the end.

```php
$request = Request::createFromGlobals();
$request->headers->set('CONTENT_TYPE', 'application/json ;charset=UTF-8'); // Forcing header for test
if ($request->getContentType() !== 'json') {
    // Return 415 (Unsupported Media Type) status code..
}
```

When checking https://tools.ietf.org/html/rfc7231#section-3.1.1.1 it seems that a space is part of the RFC spec. (Where OWS is abbreviated for Optional WhiteSpace)
```
media-type = type "/" subtype *( OWS ";" OWS parameter )
```
Current the following cases are supported:
* application/json; charset=UTF-8
* application/json;charset=UTF-8

The following are failing:
* application/json ; charset=UTF-8
* application/json ;charset=UTF-8

Commits
-------

f4866bc [HttpFoundation] Fix trailing space for mime-type with parameters
This was referenced Nov 26, 2018
Merged
Merged
Merged
Closed
Merged
This was referenced Mar 12, 2021
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@javiereguiluz javiereguiluz javiereguiluz approved these changes

Assignees
No one assigned
Labels
Bug HttpFoundation Status: Reviewed
Projects
None yet
Milestone
No milestone
< 3ECE div class="js-socket-channel js-updatable-content" data-channel="eyJjIjoicHVsbF9yZXF1ZXN0OjIzMjY2NDU2OCIsInQiOjE3NDc4NzU5NjB9--e6efd3e6130568317f7051ee0ec4cdfc7700cc403c097a9be947b74b57e9a87a" data-gid="MDExOlB1bGxSZXF1ZXN0MjMyNjY0NTY4" data-url="/symfony/symfony/issues/closing_references/partials/sidebar?source_id=232664568&source_type=PULL_REQUEST" data-channel-event-name="issue_references_updated" >
Development

Successfully merging this pull request may close these issues.
4 participants
@SaschaDens @fabpot @javiereguiluz @carsonbot
0