8000 Would make more sense that form submit buttons have boostrap class btn-primary · Issue #29114 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content
8000

Would make more sense that form submit buttons have boostrap class btn-primary #29114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JulienMaille opened this issue Nov 6, 2018 · 0 comments
Closed

Would make more sense that form submit buttons have boostrap class btn-primary #29114

JulienMaille opened this issue Nov 6, 2018 · 0 comments
Labels
Bug Form Status: Needs Review TwigBridge

Comments

@JulienMaille
Copy link

Description
Bootstrap template update from 3.3 to 4.x replaced btn-default class with btn-secondary, which results in pale grey submit buttons.

symfony/src/Symfony/Bridge/Twig/Resources/views/Form/bootstrap_4_layout.html.twig

Line 148 in 8d277ce

{%- set attr = attr|merge({class: (attr.class|default('btn-secondary') ~ ' btn')|trim}) -%}

I believe it would make more sense to give it btn-primary class as documented in the form section of Bootstrap 4 documentation: https://getbootstrap.com/docs/4.0/components/forms/

Example

Offical documentation and examples
image

Current template
image
JulienMaille pushed a commit to JulienMaille/symfony that referenced this issue Nov 6, 2018
@Nefast
Change button_widget class to btn-primary
1affbbf 
FIX symfony#29114
@JulienMaille JulienMaille mentioned this issue Nov 6, 2018
Merged
@nicolas-grekas nicolas-grekas closed this as completed Nov 8, 2018
nicolas-grekas added a commit that referenced this issue Nov 8, 2018
@nicolas-grekas
bug #29115 Change button_widget class to btn-primary (neFAST)
5916bbe 
This PR was submitted for the master branch but it was squashed and merged into the 3.4 branch instead (closes #29115).

Discussion
----------

Change button_widget class to btn-primary

FIX #29114

| Q             | A
| ------------- | ---
| Branch?       | master for features / 2.8 up to 4.1 for bug fixes <!-- see below -->
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #29114   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

Change button_widget class to btn-primary in Bootstrap 4 twig template

Commits
-------

59003bf Change button_widget class to btn-primary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Form Status: Needs Review TwigBridge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@JulienMaille @nicolas-grekas @xabbuh @carsonbot
0