8000 ControllerTrait::getUser() remove "final" · Issue #28715 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content
ControllerTrait::getUser() remove "final" #28715
Closed
@weaverryan

Description

@weaverryan

Hi guys!

In #24407, all the controller helper methods were marked as final. I think that usually makes sense, but there is a legitimate use-case for overriding getUser(), and I do it all the time :). Specifically, I'll override getUser() to add the return type for MY User for better auto-completion:

use App\Entity\User;

public function getUser(): User
{
    return parent::getUser();
}

This is a super convenient thing to be able to do. Should we consider removing the @final?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0