8000 [Validator] Validate BIC based on associated IBAN · Issue #28166 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Validator] Validate BIC based on associated IBAN #28166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sylfabre opened this issue Aug 8, 2018 · 1 comment
Closed

[Validator] Validate BIC based on associated IBAN #28166

sylfabre opened this issue Aug 8, 2018 · 1 comment
Labels
Feature Validator

Comments

@sylfabre
Copy link
Contributor
sylfabre commented Aug 8, 2018

Description
A common use case is to save an IBAN with a BIC. Symfony provides validators for both properties but they do not communicate.

We could add an optional propertyPath option (like http://symfony.com/doc/current/reference/constraints/GreaterThan.html#propertypath) on the BIC validator to check if the country code of the BIC is the same as the country code of the IBAN.

I can submit a PR if you want.

Example
For instance a user can fill a French IBAN with a German BIC which will pass both validators but a failure could be expected somewhere as it does not make sense to fill a form/entity like this.
@nicolas-grekas
Copy link
Member

PR are always welcomed :)

sylfabre added a commit to sylfabre/symfony that referenced this issue Sep 15, 2018
@sylfabre
Fix symfony#28166
5a9302c
@sylfabre sylfabre mentioned this issue Sep 16, 2018
Merged
sylfabre added a commit to sylfabre/symfony that referenced this issue Sep 16, 2018
@sylfabre
Fix symfony#28166
7dc5554
sylfabre added a commit to sylfabre/symfony that referenced this issue Sep 16, 2018
@sylfabre
Fix symfony#28166
bfa9994
sylfabre added a commit to sylfabre/symfony that referenced this issue Sep 18, 2018
@sylfabre
Fix symfony#28166
a14e697
sylfabre added a commit to sylfabre/symfony that referenced this issue Sep 18, 2018
@sylfabre
Fix symfony#28166
f1fdb27
sylfabre added a commit to sylfabre/symfony that referenced this issue Sep 18, 2018
@sylfabre
Fix symfony#28166
2d5d72d
sylfabre added a commit to sylfabre/symfony that referenced this issue Sep 18, 2018
@sylfabre
Fix symfony#28166
9fb42ba
sylfabre added a commit to sylfabre/symfony that referenced this issue Sep 18, 2018
@sylfabre
Fix symfony#28166
41b422b
sylfabre added a commit to sylfabre/symfony that referenced this issue Sep 20, 2018< 10000 /relative-time>
@sylfabre
Fix symfony#28166
bba0264
sylfabre added a commit to sylfabre/symfony that referenced this issue Sep 20, 2018
@sylfabre
Fix symfony#28166
98bb643
sylfabre added a commit to sylfabre/symfony that referenced this issue Sep 20, 2018
@sylfabre
[Validator] Checking a BIC along with an IBAN
645b016 
Fix symfony#28166
sylfabre added a commit to sylfabre/symfony that referenced this issue Sep 24, 2018
@sylfabre
[Validator] Checking a BIC along with an IBAN
b4b0056 
Fix symfony#28166
sylfabre added a commit to sylfabre/symfony that referenced this issue Sep 24, 2018
@sylfabre
[Validator] Checking a BIC along with an IBAN
fc6b756 
Fix symfony#28166
sylfabre added a commit to sylfabre/symfony that referenced this issue Sep 24, 2018
@sylfabre
[Validator] Checking a BIC along with an IBAN
3de6a31 
Fix symfony#28166
sylfabre added a commit to sylfabre/symfony that referenced this issue Sep 25, 2018
@sylfabre
[Validator] Checking a BIC along with an IBAN
f2db7ad 
Fix symfony#28166
sylfabre added a commit to sylfabre/symfony that referenced this issue Oct 22, 2018
@sylfabre
[Validator] Checking a BIC along with an IBAN
bf50b6b 
Fix symfony#28166
sylfabre added a commit to sylfabre/symfony that referenced this issue Oct 22, 2018
@sylfabre
[Validator] Checking a BIC along with an IBAN
a7bbdc7 
Fix symfony#28166
sylfabre added a commit to sylfabre/symfony that referenced this issue Oct 22, 2018
@sylfabre
[Validator] Checking a BIC along with an IBAN
dc8a9c1 
Fix symfony#28166
sylfabre added a commit to sylfabre/symfony that referenced this issue Oct 22, 2018
@sylfabre
[Validator] Checking a BIC along with an IBAN
25ce7de 
Fix symfony#28166
sylfabre added a commit to sylfabre/symfony that referenced this issue Oct 23, 2018
@sylfabre
[Validator] Checking a BIC along with an IBAN
bfd52dd 
Fix symfony#28166
sylfabre added a commit to sylfabre/symfony that referenced this issue Nov 5, 2018
@sylfabre
[Validator] Checking a BIC along with an IBAN
435489b 
Fix symfony#28166
sylfabre added a commit to sylfabre/symfony that referenced this issue Nov 5, 2018
@sylfabre
[Validator] Checking a BIC along with an IBAN
491bbe7 
Fix symfony#28166
sylfabre added a commit to sylfabre/symfony that referenced this issue Nov 5, 2018
@sylfabre
[Validator] Checking a BIC along with an IBAN
bb6be15 
Fix symfony#28166
nicolas-grekas added a commit that referenced this issue Dec 1, 2018
@nicolas-grekas
feature #28479 [Validator] Checking a BIC along with an IBAN (sylfabre)
cc0be40 
This PR was merged into the 4.3-dev branch.

Discussion
----------

[Validator] Checking a BIC along with an IBAN

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #28166
| License       | MIT
| Doc PR        | symfony/symfony-docs#10349

A BIC comes usually with an IBAN so it's better to check that they are associated. This PR provides an `iban` option to `Symfony\Component\Validator\Constraints\Bic` to check the BIC against an IBAN.

It also provides an `ibanPropertyPath` to retrieves the IBAN using the property accessor like with comparison constraints.

Commits
-------

bb6be15 [Validator] Checking a BIC along with an IBAN Fix #28166
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Validator
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nicolas-grekas @xabbuh @sylfabre
0