[Workflow] BC Break in Event class (potential real issue)

**Symfony version(s) affected**: 4.1.x

**Description**  

```php
$event = new \Symfony\Component\Workflow\Event($subject, $marking, $transition);
```

This previously was an authorized usage. With 4.1 it now fails. But the last (and missing here) arg is still optional while it generates the throw of an exception.

This is due to [this commit](https://github.com/symfony/symfony/commit/bd1f2c858385bca965cb6e8d32b1a21085029981#diff-7ced8e5ceace060a06472087086f06eaR49).

**Possible Solution**  

I thinks something's wrong with the exception `InvalidArgumentException`, I suggest to remove it for now and adding it in 5.0.

https://github.com/symfony/symfony/blob/bd1f2c858385bca965cb6e8d32b1a21085029981/src/Symfony/Component/Workflow/Event/Event.php#L38-L51

	public function __construct($subject, Marking $marking, Transition $transition, $workflow = null)
	{
	$this->subject = $subject;
	$this->marking = $marking;
	$this->transition = $transition;
	if (is_string($workflow)) {
	@trigger_error(sprintf('Passing a string as 4th parameter of "%s" is deprecated since Symfony 4.1. Pass a %s instance instead.', __METHOD__, WorkflowInterface::class), E_USER_DEPRECATED);
	$this->workflowName = $workflow;
	} elseif ($workflow instanceof WorkflowInterface) {
	$this->workflow = $workflow;
	} else {
	throw new InvalidArgumentException(sprintf('The 4th parameter of "%s" should be a "%s" instance instead.', __METHOD__, WorkflowInterface::class));
	}
	}

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Uh oh!

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions