10000 [Twig][DX] report unknown folders in templates/bundles in debug:twig · Issue #26898 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Twig][DX] report unknown folders in templates/bundles in debug:twig #26898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dkarlovi opened this issue Apr 12, 2018 · 1 comment
Closed

[Twig][DX] report unknown folders in templates/bundles in debug:twig #26898

dkarlovi opened this issue Apr 12, 2018 · 1 comment
Labels
DX DX = Developer eXperience (anything that improves the experience of using Symfony) Feature Good first issue Ideal for your first contribution! (some Symfony experience may be required) TwigBundle

Comments

@dkarlovi
Copy link
Contributor
Q A
Bug report? no
Feature request? yes
BC Break report? no
RFC? no
Symfony version 4.0

Had an issue in FOSOAuthServerBundle where users had a hard time discovering what the proper path for overriding bundle views is (also, me).

A small tweak for debug:twig might be to note folders in templates/bundles which don't (properly) map to any known bundle?

Say:

Path "templates/bundles/FOSOAuthServer" not matching any bundle found, did you mean "templates/bundles/FOSOAuthServerBundle"?
@javiereguiluz javiereguiluz added Feature TwigBundle DX DX = Developer eXperience (anything that improves the experience of using Symfony) labels Apr 12, 2018
@stof stof added the Good first issue Ideal for your first contribution! (some Symfony experience may be required) label Apr 12, 2018
@pmontoya
Copy link

It's for me!

@pmontoya pmontoya mentioned this issue Apr 13, 2018
Merged
pmontoya pushed a commit to pmontoya/symfony that referenced this issue Jun 13, 2018
refs symfony#26898
9fd49cd 
Move changelog entry to 4.1.0 to 4.2.0
pmontoya pushed a commit to pmontoya/symfony that referenced this issue Jun 13, 2018
refs symfony#26898
9d534ee 
Check if projectDir is not null before loop
pmontoya pushed a commit to pmontoya/symfony that referenced this issue Jun 13, 2018
refs symfony#26898
c687afc 
Check if projectDir is not null before loop
pmontoya pushed a commit to pmontoya/symfony that referenced this issue Jun 18, 2018
refs symfony#26898
da0c589 
Move changelog entry to 4.1.0 to 4.2.0
pmontoya pushed a commit to pmontoya/symfony that referenced this issue Jun 18, 2018
refs symfony#26898
da42b3e 
Check if projectDir is not null before loop
pmontoya pushed a commit to pmontoya/symfony that referenced this issue Jun 18, 2018
refs symfony#26898
acfb325 
Remove unnecessary loop
Trim messages on build rather than on display
nicolas-grekas added a commit that referenced this issue Jun 19, 2018
@nicolas-grekas
feature #26919 [TwigBridge] Added bundle name suggestion on wrongly o…
d148fa7 
…verrided templates paths (pmontoya, Pascal Montoya)

This PR was merged into the 4.2-dev branch.

Discussion
----------

[TwigBridge] Added bundle name suggestion on wrongly overrided templates paths

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #26898
| License       | MIT

Report unknown folders in templates/bundles in debug:twig and make suggestions if any

Developped with @bricejulia

Commits
-------

acfb325 refs #26898 Remove unnecessary loop Trim messages on build rather than on display
da42b3e refs #26898 Check if projectDir is not null before loop
da0c589 refs #26898 Move changelog entry to 4.1.0 to 4.2.0
7d9467a Add an entry on json export format
bab9d99 Use %twig.default_path% parameter and search in old folder structure too
1758de2 [TwigBridge] Added bundle name suggestion on wrongly overrided templates paths
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
DX DX = Developer eXperience (anything that improves the experience of using Symfony) Feature Good first issue Ideal for your first contribution! (some Symfony experience may be required) TwigBundle
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@javiereguiluz @dkarlovi @nicolas-grekas @stof @pmontoya
0