8000 [DX] Jump to Exception in Chain Using Breadcrumbs · Issue #26824 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[DX] Jump to Exception in Chain Using Breadcrumbs #26824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kiler129 opened this issue Apr 5, 2018 · 2 comments
Closed

[DX] Jump to Exception in Chain Using Breadcrumbs #26824

kiler129 opened this issue Apr 5, 2018 · 2 comments
Labels
DX DX = Developer eXperience (anything that improves the experience of using Symfony) WebProfilerBundle

Comments

@kiler129
Copy link
Contributor
kiler129 commented Apr 5, 2018
Q A
Bug report? no
Feature request? yes
BC Break report? no
Symfony version 4.1

Sometimes exception chains can be long:
image

In order to get to them developer needs to scroll to a particular one. I suggest we add link with # pointing to an exception in chain as well as add ids to each of the foldable boxes with exceptions.

This small change will allow to quickly jump to interesting exception just by clicking on the top bar.

WDYT?
@javiereguiluz javiereguiluz added the DX DX = Developer eXperience (anything that improves the experience of using Symfony) label Apr 8, 2018
@javiereguiluz
Copy link
Member

I think it's a brilliant idea to make this page more usable! @kiler129 would you like to give a shot at this and send a pull request? Thanks!

@javiereguiluz javiereguiluz added the WebProfilerBundle label Apr 8, 2018 < 8000 /div>
@kiler129
Copy link
Contributor Author
kiler129 commented Apr 8, 2018

@javiereguiluz: Sure, I will submit PR today :)

kiler129 added a commit to kiler129/symfony that referenced this issue May 19, 2018
@kiler129
feature symfony#26824 add exception chain breadcrumbs navigation
5551e0c
@kiler129 kiler129 mentioned this issue May 19, 2018
Merged
@fabpot fabpot closed this as completed Jun 14, 2018
fabpot added a commit that referenced this issue Jun 14, 2018
@fabpot
feature #27315 [TwigBundle] add exception chain breadcrumbs navigatio…
b560883 
…n (kiler129)

This PR was merged into the 4.2-dev branch.

Discussion
----------

[TwigBundle] add exception chain breadcrumbs navigation

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #26824
| License       | MIT
| Doc PR        | -

Small DX improvement allowing to jump to exception in chain:
![preview](https://media.giphy.com/media/23chfZo9oFzdOrZzYl/giphy.gif)

Commits
-------

5551e0c feature #26824 add exception chain breadcrumbs navigation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
DX DX = Developer eXperience (anything that improves the experience of using Symfony) WebProfilerBundle
Projects
None yet
Milestone
No milestone
36C5
Development

No branches or pull requests
3 participants
@fabpot @javiereguiluz @kiler129
0