8000 open_basedir restriction in effect · Issue #26563 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

open_basedir restriction in effect #26563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
temperatur opened this issue Mar 16, 2018 · 3 comments
Closed

open_basedir restriction in effect #26563

temperatur opened this issue Mar 16, 2018 · 3 comments
Labels
Bug Process Status: Needs Review

Comments

@temperatur
Copy link
Contributor

Hi,
The https://github.com/contao/contao-manager uses Composer to update the installation.
The manager just work fine until it gets to the post-install-cmd Script of the composer.
Contao is using the PhpExecutableFinder to get the php binaries. If the open_basedir is set is_file(PHP_BINARY) is false.

symfony/src/Symfony/Component/Process/PhpExecutableFinder.php

Line 50 in 5cf0a2e

if (PHP_BINARY && in_array(PHP_SAPI, array('cli', 'cli-server', 'phpdbg')) && is_file(PHP_BINARY)) {

Here the contao issue contao/manager-bundle#57 for more information.
@Tobion
Copy link
Contributor
Tobion commented Mar 18, 2018

So what do you propose? Just removing the file check?

@temperatur
Copy link
Contributor Author

Yes, since the PHP_BINARY constant specifies the PHP binary path during script execution.
So if it set there is no need to check if the file exists because if we are using cli we already used the binary.

@Tobion
Copy link
Contributor
Tobion commented Mar 19, 2018

Could you create a PR?

temperatur added a commit to temperatur/symfony that referenced this issue Mar 19, 2018
@temperatur
Fixes symfony#26563 (open_basedir restriction in effect)
703ce2c 
If the open_basedir is set is_file(PHP_BINARY) is false.
@temperatur temperatur mentioned this issue Mar 19, 2018
Closed
nicolas-grekas pushed a commit that referenced this issue Mar 19, 2018
@temperatur @nicolas-grekas
Fixes #26563 (open_basedir restriction in effect)
7a04976 
If the open_basedir is set is_file(PHP_BINARY) is false.
nicolas-grekas added a commit that referenced this issue Mar 19, 2018
@nicolas-grekas
bug #26598 Fixes #26563 (open_basedir restriction in effect) (tempera…
0222fde 
…tur)

This PR was submitted for the 4.0 branch but it was merged into the 2.7 branch instead (closes #26598).

Discussion
----------

Fixes #26563 (open_basedir restriction in effect)

If the open_basedir is set is_file(PHP_BINARY) is false.

| Q             | A
| ------------- | ---
| Branch?       | 4.0
| Bug fix?      | yes/
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #26563
| License       | MIT
| Doc PR        |

If we are using cli we already used the binary so there is no need to check if the file exists.

Commits
-------

7a04976 Fixes #26563 (open_basedir restriction in effect)
nicolas-grekas added a commit that referenced this issue Mar 19, 2018
@nicolas-grekas
Merge branch '2.7' into 2.8
af6be35 
* 2.7:
  [Config] Handle nullable node name + fix inheritdocs
  [Security] added userChecker to SimpleAuthenticationProvider
  [Debug] fix test
  Fix typo in test method name
  Fixes #26563 (open_basedir restriction in effect)
  [Debug] Reset previous exception handler ealier to prevent infinite loop
  add hint in Github pull request template
  [Validator] Fix docblock of ClassMetadata#members
  [BrowserKit] Fix cookie path handling when $domain is null
  [DoctrineBridge] Don't rely on ClassMetadataInfo->hasField in DoctrineOrmTypeGuesser anymore
  [BrowserKit] Improves CookieJar::get
  [BrowserKit] Fix Cookie's PHPDoc
  [DomCrawler] Change bad wording in ChoiceFormField::untick
  [DomCrawler] Fix the PHPDoc of ChoiceFormField::setValue
  [DomCrawler] Avoid a useless call to strtolower
  [FrameworkBundle] HttpCache is not longer abstract
  [DomCrawler] extract(): fix a bug when the attribute list is empty
  [Config] Backport string|null api for node names
nicolas-grekas added a commit that referenced this issue Mar 19, 2018
@nicolas-grekas
Merge branch '2.8' into 3.4
34d5b5e 
* 2.8: (29 commits)
  [Console] Fix docblock of DescriptorInterface::describe
  [Config] Handle nullable node name + fix inheritdocs
  [Security] added userChecker to SimpleAuthenticationProvider
  [Debug] fix test
  Fix typo in test method name
  Fixes #26563 (open_basedir restriction in effect)
  [Debug] Reset previous exception handler ealier to prevent infinite loop
  add hint in Github pull request template
  [Validator] Fix docblock of ClassMetadata#members
  [BrowserKit] Fix cookie path handling when $domain is null
  [DoctrineBridge] Don't rely on ClassMetadataInfo->hasField in DoctrineOrmTypeGuesser anymore
  [BrowserKit] Improves CookieJar::get
  [BrowserKit] Fix Cookie's PHPDoc
  [DomCrawler] Change bad wording in ChoiceFormField::untick
  [DomCrawler] Fix the PHPDoc of ChoiceFormField::setValue
  [DomCrawler] Avoid a useless call to strtolower
  [FrameworkBundle] HttpCache is not longer abstract
  Php Inspections (EA Ultimate): address some of one-time used local variables
  [Intl] Load locale aliases to support alias fallbacks
  [CssSelector] Fix CSS identifiers parsing - they can start with dash
  ...
nicolas-grekas added a commit that referenced this issue Mar 19, 2018
@nicolas-grekas
Merge branch '3.4' into 4.0
1f119cc 
* 3.4: (32 commits)
  [Form] fix tests and deps
  [Cache] Rely on mock for Doctrine ArrayCache
  [FrameworkBundle] Respect debug mode when warm up annotations
  [Console] Fix docblock of DescriptorInterface::describe
  [Config] Handle nullable node name + fix inheritdocs
  [Security] added userChecker to SimpleAuthenticationProvider
  [Debug] fix test
  Fix typo in test method name
  Fixes #26563 (open_basedir restriction in effect)
  [Debug] Reset previous exception handler ealier to prevent infinite loop
  add hint in Github pull request template
  [Validator] Fix docblock of ClassMetadata#members
  [BrowserKit] Fix cookie path handling when $domain is null
  [DoctrineBridge] Don't rely on ClassMetadataInfo->hasField in DoctrineOrmTypeGuesser anymore
  [BrowserKit] Improves CookieJar::get
  [BrowserKit] Fix Cookie's PHPDoc
  [DomCrawler] Change bad wording in ChoiceFormField::untick
  [DomCrawler] Fix the PHPDoc of ChoiceFormField::setValue
  [DomCrawler] Avoid a useless call to strtolower
  [FrameworkBundle] HttpCache is not longer abstract
  ...
nicolas-grekas added a commit that referenced this issue Mar 19, 2018
@nicolas-grekas
Merge branch '4.0'
2ca8657 
* 4.0: (32 commits)
  [Form] fix tests and deps
  [Cache] Rely on mock for Doctrine ArrayCache
  [FrameworkBundle] Respect debug mode when warm up annotations
  [Console] Fix docblock of DescriptorInterface::describe
  [Config] Handle nullable node name + fix inheritdocs
  [Security] added userChecker to SimpleAuthenticationProvider
  [Debug] fix test
  Fix typo in test method name
  Fixes #26563 (open_basedir restriction in effect)
  [Debug] Reset previous exception handler ealier to prevent infinite loop
  add hint in Github pull request template
  [Validator] Fix docblock of ClassMetadata#members
  [BrowserKit] Fix cookie path handling when $domain is null
  [DoctrineBridge] Don't rely on ClassMetadataInfo->hasField in DoctrineOrmTypeGuesser anymore
  [BrowserKit] Improves CookieJar::get
  [BrowserKit] Fix Cookie's PHPDoc
  [DomCrawler] Change bad wording in ChoiceFormField::untick
  [DomCrawler] Fix the PHPDoc of ChoiceFormField::setValue
  [DomCrawler] Avoid a useless call to strtolower
  [FrameworkBundle] HttpCache is not longer abstract
  ...
This was referenced Apr 2, 2018
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Process Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@javiereguiluz @nicolas-grekas @Tobion @carsonbot @temperatur
0